From: Ed Schouten <ed@nuxi.nl>
To: DJ Delorie <dj@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Likely incorrect patch: remove the faulty basename() prototype from libiberty
Date: Sun, 29 May 2016 17:24:00 -0000 [thread overview]
Message-ID: <CABh_MK=q7sXBbV_XDXsdMNG46ppVz1n-1yn-1WpNzBO9ecAVNQ@mail.gmail.com> (raw)
In-Reply-To: <xnbn3o3ibh.fsf@greed.delorie.com>
Hi DJ,
2016-05-29 19:06 GMT+02:00 DJ Delorie <dj@redhat.com>:
> I think the right path to go down is to add libgen.h to the list in
> AC_CHECK_HEADERS for every project that uses basename() (including
> libiberty itself, and binutils, gdb, and gcc), and then everyone who
> uses basename() from libiberty.h would need to include libgen.h *if*
> it's found by configure.
If the users of libiberty have to be explicitly patched up to include
<libgen.h> to get basename(), what's the use of having any of it part
of libiberty in the first place? Wouldn't that practically be the same
as removing basename() from libiberty altogether?
That approach also sounds fine by me, but then again, I'm just an
outsider to this project.
--
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717
next prev parent reply other threads:[~2016-05-29 17:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 14:58 Ed Schouten
2016-05-29 16:32 ` DJ Delorie
2016-05-29 16:36 ` Ed Schouten
2016-05-29 17:06 ` DJ Delorie
2016-05-29 17:24 ` Ed Schouten [this message]
2016-05-29 17:35 ` DJ Delorie
2016-06-02 21:27 ` Joseph Myers
2016-06-03 9:37 ` Ed Schouten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABh_MK=q7sXBbV_XDXsdMNG46ppVz1n-1yn-1WpNzBO9ecAVNQ@mail.gmail.com' \
--to=ed@nuxi.nl \
--cc=dj@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox