From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6414 invoked by alias); 29 May 2016 17:24:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6373 invoked by uid 89); 29 May 2016 17:24:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=(unknown), H*F:D*nl X-HELO: mail-yw0-f178.google.com Received: from mail-yw0-f178.google.com (HELO mail-yw0-f178.google.com) (209.85.161.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 29 May 2016 17:24:15 +0000 Received: by mail-yw0-f178.google.com with SMTP id c127so146282146ywb.1 for ; Sun, 29 May 2016 10:24:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=MoZUZeG2B6f68TbkEVH2xuj6lFmZ8sfBHRi+NlSnP4M=; b=LvzQb5xhCrD4tIVr5DexGFham7CFS9vr7ZrCiT0pPdGIpRmXfIWwfOXPLQobpQvDqw dfE4Uxutd/A3eMx3qSGiSAWKbO8BShrnnYqoCVpfwdeFeeMnDj2kGrf+Z8dhyPyjJDuj wzR8KgmVp/HrpQkwJFeBHIcnclYYv8Uv6BkEMD04ZGX0TrKaE3t/xqeGqa/G9YcsMoR7 hVztmL0D9fKgF3HOtOYmR1vd7Py6rcbS69m6J0IEdFEWOSZdGimok+rwzI7E9irAWrBk laTUIcJAonGrbLYyFQkCWC0A4DF86DH/na5DMfq6nZShHrf7c2Y/6qss9sXMJzX6tXlv sb2w== X-Gm-Message-State: ALyK8tJWDXP5Rkfhfwmt8iJP6+gqRWW8MAReFDhg+hegC29SP+RhGJS6Q3kLTwyFBvmKOo5lKUaNe55wrUAKvQ== MIME-Version: 1.0 X-Received: by 10.13.218.131 with SMTP id c125mr15024386ywe.310.1464542653296; Sun, 29 May 2016 10:24:13 -0700 (PDT) Received: by 10.13.201.199 with HTTP; Sun, 29 May 2016 10:24:13 -0700 (PDT) In-Reply-To: References: Date: Sun, 29 May 2016 17:24:00 -0000 Message-ID: Subject: Re: Likely incorrect patch: remove the faulty basename() prototype from libiberty From: Ed Schouten To: DJ Delorie Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-05/txt/msg00528.txt.bz2 Hi DJ, 2016-05-29 19:06 GMT+02:00 DJ Delorie : > I think the right path to go down is to add libgen.h to the list in > AC_CHECK_HEADERS for every project that uses basename() (including > libiberty itself, and binutils, gdb, and gcc), and then everyone who > uses basename() from libiberty.h would need to include libgen.h *if* > it's found by configure. If the users of libiberty have to be explicitly patched up to include to get basename(), what's the use of having any of it part of libiberty in the first place? Wouldn't that practically be the same as removing basename() from libiberty altogether? That approach also sounds fine by me, but then again, I'm just an outsider to this project. -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717