From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57247 invoked by alias); 29 May 2016 16:32:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57235 invoked by uid 89); 29 May 2016 16:32:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:777 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 29 May 2016 16:32:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 73F5B6265B; Sun, 29 May 2016 16:32:17 +0000 (UTC) Received: from greed.delorie.com (ovpn-116-6.phx2.redhat.com [10.3.116.6]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4TGWGgN003634 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 29 May 2016 12:32:17 -0400 Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.14.7/8.14.7) with ESMTP id u4TGWFnr023112; Sun, 29 May 2016 12:32:16 -0400 From: DJ Delorie To: Ed Schouten Cc: gdb-patches@sourceware.org Subject: Re: Likely incorrect patch: remove the faulty basename() prototype from libiberty In-Reply-To: (message from Ed Schouten on Sun, 29 May 2016 16:58:28 +0200) Date: Sun, 29 May 2016 16:32:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00523.txt.bz2 Ed Schouten writes: > For now I'm solving this by simply patching up libiberty to pull in > the declaration from libgen.h. This seems to make everything build > again. Unless you check *every* one of those operating systems, and put in a configure test for libgen and test for it, this patch is wrong. Most likely, you're not calling configure right, else it would have seen the right prototype and skipped this part of the header. Or libiberty's configure and tests need to check for libgen.h as well as the other headers it's checking for. Either way, you can't blindly depend on a header being present and useful. "Seems to" is insufficient evidence that a patch is correct.