* PATCH: fix indentation in remote.c:fetch_register_using_p
@ 2004-12-17 22:37 Jim Blandy
2004-12-18 1:47 ` Andrew Cagney
0 siblings, 1 reply; 3+ messages in thread
From: Jim Blandy @ 2004-12-17 22:37 UTC (permalink / raw)
To: gdb-patches
2004-12-17 Jim Blandy <jimb@redhat.com>
* remote.c (fetch_register_using_p): Indentation cleanup.
Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.154
diff -c -p -r1.154 remote.c
*** gdb/remote.c 7 Dec 2004 20:21:32 -0000 1.154
--- gdb/remote.c 17 Dec 2004 22:16:41 -0000
*************** fetch_register_using_p (int regnum)
*** 3193,3213 ****
*p++ = '\0';
remote_send (buf, rs->remote_packet_size);
if (buf[0] != 0 && buf[0] != 'E') {
! p = buf;
! i = 0;
! while (p[0] != 0) {
! if (p[1] == 0) {
! error("fetch_register_using_p: early buf termination");
! return 0;
! }
! regp[i++] = fromhex (p[0]) * 16 + fromhex (p[1]);
! p += 2;
}
regcache_raw_supply (current_regcache, regnum, regp);
return 1;
! }
! return 0;
}
static void
--- 3193,3213 ----
*p++ = '\0';
remote_send (buf, rs->remote_packet_size);
if (buf[0] != 0 && buf[0] != 'E') {
! p = buf;
! i = 0;
! while (p[0] != 0) {
! if (p[1] == 0) {
! error("fetch_register_using_p: early buf termination");
! return 0;
! }
! regp[i++] = fromhex (p[0]) * 16 + fromhex (p[1]);
! p += 2;
}
regcache_raw_supply (current_regcache, regnum, regp);
return 1;
! }
! return 0;
}
static void
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: fix indentation in remote.c:fetch_register_using_p
2004-12-17 22:37 PATCH: fix indentation in remote.c:fetch_register_using_p Jim Blandy
@ 2004-12-18 1:47 ` Andrew Cagney
2004-12-21 21:43 ` Jim Blandy
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2004-12-18 1:47 UTC (permalink / raw)
To: Jim Blandy; +Cc: gdb-patches
> if (buf[0] != 0 && buf[0] != 'E') {
Close, but no cigar. Note the ``}'' :-)
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: fix indentation in remote.c:fetch_register_using_p
2004-12-18 1:47 ` Andrew Cagney
@ 2004-12-21 21:43 ` Jim Blandy
0 siblings, 0 replies; 3+ messages in thread
From: Jim Blandy @ 2004-12-21 21:43 UTC (permalink / raw)
To: Andrew Cagney; +Cc: gdb-patches
Andrew Cagney <cagney@gnu.org> writes:
> > if (buf[0] != 0 && buf[0] != 'E') {
>
> Close, but no cigar. Note the ``}'' :-)
That's what I get for using Emacs instead of gdb_indent.sh. Here's
what that script does. I've committed it.
2004-12-21 Jim Blandy <jimb@redhat.com>
* remote.c (fetch_register_using_p): Fix formatting.
Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.155
diff -c -p -r1.155 remote.c
*** gdb/remote.c 17 Dec 2004 22:19:51 -0000 1.155
--- gdb/remote.c 21 Dec 2004 21:18:39 -0000
*************** fetch_register_using_p (int regnum)
*** 3192,3211 ****
p += hexnumstr (p, regnum);
*p++ = '\0';
remote_send (buf, rs->remote_packet_size);
! if (buf[0] != 0 && buf[0] != 'E') {
! p = buf;
! i = 0;
! while (p[0] != 0) {
! if (p[1] == 0) {
! error("fetch_register_using_p: early buf termination");
! return 0;
! }
! regp[i++] = fromhex (p[0]) * 16 + fromhex (p[1]);
! p += 2;
}
- regcache_raw_supply (current_regcache, regnum, regp);
- return 1;
- }
return 0;
}
--- 3192,3214 ----
p += hexnumstr (p, regnum);
*p++ = '\0';
remote_send (buf, rs->remote_packet_size);
! if (buf[0] != 0 && buf[0] != 'E')
! {
! p = buf;
! i = 0;
! while (p[0] != 0)
! {
! if (p[1] == 0)
! {
! error ("fetch_register_using_p: early buf termination");
! return 0;
! }
! regp[i++] = fromhex (p[0]) * 16 + fromhex (p[1]);
! p += 2;
! }
! regcache_raw_supply (current_regcache, regnum, regp);
! return 1;
}
return 0;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-12-21 21:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-17 22:37 PATCH: fix indentation in remote.c:fetch_register_using_p Jim Blandy
2004-12-18 1:47 ` Andrew Cagney
2004-12-21 21:43 ` Jim Blandy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox