From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-37583-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 1657 invoked by alias); 21 Dec 2004 21:30:35 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 1489 invoked from network); 21 Dec 2004 21:30:14 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 21 Dec 2004 21:30:14 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iBLLUDO1004720
	for <gdb-patches@sources.redhat.com>; Tue, 21 Dec 2004 16:30:13 -0500
Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iBLLPkr19951;
	Tue, 21 Dec 2004 16:25:47 -0500
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: fix indentation in remote.c:fetch_register_using_p
References: <vt2vfb0lgb8.fsf@zenia.home> <41C385FF.7080606@gnu.org>
From: Jim Blandy <jimb@redhat.com>
Date: Tue, 21 Dec 2004 21:43:00 -0000
In-Reply-To: <41C385FF.7080606@gnu.org>
Message-ID: <vt2r7ljjqgu.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-12/txt/msg00418.txt.bz2

Andrew Cagney <cagney@gnu.org> writes:

> >     if (buf[0] != 0 && buf[0] != 'E') {
> 
> Close, but no cigar.  Note the ``}'' :-)

That's what I get for using Emacs instead of gdb_indent.sh.  Here's
what that script does.  I've committed it.

2004-12-21  Jim Blandy  <jimb@redhat.com>

	* remote.c (fetch_register_using_p): Fix formatting.
	
Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.155
diff -c -p -r1.155 remote.c
*** gdb/remote.c	17 Dec 2004 22:19:51 -0000	1.155
--- gdb/remote.c	21 Dec 2004 21:18:39 -0000
*************** fetch_register_using_p (int regnum)
*** 3192,3211 ****
    p += hexnumstr (p, regnum);
    *p++ = '\0';
    remote_send (buf, rs->remote_packet_size);
!   if (buf[0] != 0 && buf[0] != 'E') {
!     p = buf;
!     i = 0;
!     while (p[0] != 0) {
!       if (p[1] == 0) {
!         error("fetch_register_using_p: early buf termination");
!         return 0;
!       }
!       regp[i++] = fromhex (p[0]) * 16 + fromhex (p[1]);
!       p += 2;
      }
-     regcache_raw_supply (current_regcache, regnum, regp);
-     return 1;
-   }
  
    return 0;
  }
--- 3192,3214 ----
    p += hexnumstr (p, regnum);
    *p++ = '\0';
    remote_send (buf, rs->remote_packet_size);
!   if (buf[0] != 0 && buf[0] != 'E')
!     {
!       p = buf;
!       i = 0;
!       while (p[0] != 0)
! 	{
! 	  if (p[1] == 0)
! 	    {
! 	      error ("fetch_register_using_p: early buf termination");
! 	      return 0;
! 	    }
! 	  regp[i++] = fromhex (p[0]) * 16 + fromhex (p[1]);
! 	  p += 2;
! 	}
!       regcache_raw_supply (current_regcache, regnum, regp);
!       return 1;
      }
  
    return 0;
  }