From: Jim Blandy <jimb@redhat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: fix indentation in remote.c:fetch_register_using_p
Date: Tue, 21 Dec 2004 21:43:00 -0000 [thread overview]
Message-ID: <vt2r7ljjqgu.fsf@zenia.home> (raw)
In-Reply-To: <41C385FF.7080606@gnu.org>
Andrew Cagney <cagney@gnu.org> writes:
> > if (buf[0] != 0 && buf[0] != 'E') {
>
> Close, but no cigar. Note the ``}'' :-)
That's what I get for using Emacs instead of gdb_indent.sh. Here's
what that script does. I've committed it.
2004-12-21 Jim Blandy <jimb@redhat.com>
* remote.c (fetch_register_using_p): Fix formatting.
Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.155
diff -c -p -r1.155 remote.c
*** gdb/remote.c 17 Dec 2004 22:19:51 -0000 1.155
--- gdb/remote.c 21 Dec 2004 21:18:39 -0000
*************** fetch_register_using_p (int regnum)
*** 3192,3211 ****
p += hexnumstr (p, regnum);
*p++ = '\0';
remote_send (buf, rs->remote_packet_size);
! if (buf[0] != 0 && buf[0] != 'E') {
! p = buf;
! i = 0;
! while (p[0] != 0) {
! if (p[1] == 0) {
! error("fetch_register_using_p: early buf termination");
! return 0;
! }
! regp[i++] = fromhex (p[0]) * 16 + fromhex (p[1]);
! p += 2;
}
- regcache_raw_supply (current_regcache, regnum, regp);
- return 1;
- }
return 0;
}
--- 3192,3214 ----
p += hexnumstr (p, regnum);
*p++ = '\0';
remote_send (buf, rs->remote_packet_size);
! if (buf[0] != 0 && buf[0] != 'E')
! {
! p = buf;
! i = 0;
! while (p[0] != 0)
! {
! if (p[1] == 0)
! {
! error ("fetch_register_using_p: early buf termination");
! return 0;
! }
! regp[i++] = fromhex (p[0]) * 16 + fromhex (p[1]);
! p += 2;
! }
! regcache_raw_supply (current_regcache, regnum, regp);
! return 1;
}
return 0;
}
prev parent reply other threads:[~2004-12-21 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-17 22:37 Jim Blandy
2004-12-18 1:47 ` Andrew Cagney
2004-12-21 21:43 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt2r7ljjqgu.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox