[RFA/testsuite] Remove KFAILs in sep.exp

[RFA/testsuite] Remove KFAILs in sep.exp

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hello,

Now that our dwarf2reader handles included files, the two tests
in sep.exp that used to KFAIL now KPASS. I therefore suggest the
attached patch to remove the setup_kfail on these tests.

I removed the entire machinery that computes the debug format,
since it is no longer useful.

2004-05-05  Joel Brobecker  <brobecker@gnat.com>

        * gdb.base/sep.exp: No longer setup_kfail when the program was
        built with dwarf2.

Tested on x86-linux.
Ok to apply?

Thanks,
-- 
Joel

[-- Attachment #2: sep.exp.diff --]
[-- Type: text/plain, Size: 1587 bytes --]

Index: gdb.base/sep.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/sep.exp,v
retrieving revision 1.2
diff -u -r1.2 sep.exp
--- gdb.base/sep.exp	12 Apr 2004 20:22:54 -0000	1.2
+++ gdb.base/sep.exp	5 May 2004 19:14:48 -0000
@@ -29,18 +29,6 @@
     gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
 }
 
-# Get the debug info format, using the get_debug_format.
-# Note that the function above needs the current source file to be set,
-# so we need to send a dummy command first which side effect is to set
-# the current source file.
-gdb_exit
-gdb_start
-gdb_load ${binfile}
-gdb_test "list sep.c:1" ".*" "dummy command to set the current source file"
-get_debug_format
-
-# We need to restart the debugger, because the method used to compute
-# the debug format (above) affects this testcase.
 gdb_exit
 gdb_start
 gdb_reinitialize_dir $srcdir/$subdir
@@ -56,10 +44,6 @@
 # say_hello is good enough, and avoid unnecessary failures is someone
 # decides later to reformat sep-proc.c.
 
-if { [test_debug_format "DWARF 2"] } then {
-    setup_kfail "symtab/1607" *-*-*
-}
-
 gdb_test "list sep-proc.c:23" \
          "void.*say_hello.*" \
          "list using location inside included file"
@@ -71,10 +55,6 @@
 gdb_start
 gdb_reinitialize_dir $srcdir/$subdir
 gdb_load ${binfile}
-
-if { [test_debug_format "DWARF 2"] } then {
-    setup_kfail "symtab/1607" *-*-*
-}
 
 set test "breakpoint inside included file"
 gdb_test_multiple "break sep-proc.c:25" "$test" {

Re: [RFA/testsuite] Remove KFAILs in sep.exp

[Jim Blandy]

Joel Brobecker <brobecker@gnat.com> writes:
> Now that our dwarf2reader handles included files, the two tests
> in sep.exp that used to KFAIL now KPASS. I therefore suggest the
> attached patch to remove the setup_kfail on these tests.
> 
> I removed the entire machinery that computes the debug format,
> since it is no longer useful.
> 
> 2004-05-05  Joel Brobecker  <brobecker@gnat.com>
> 
>         * gdb.base/sep.exp: No longer setup_kfail when the program was
>         built with dwarf2.
> 
> Tested on x86-linux.
> Ok to apply?

Looks good.

Re: [RFA/testsuite] Remove KFAILs in sep.exp

[Joel Brobecker]

> > 2004-05-05  Joel Brobecker  <brobecker@gnat.com>
> > 
> >         * gdb.base/sep.exp: No longer setup_kfail when the program was
> >         built with dwarf2.
> > 
> 
> Looks good.

Thanks a lot. Checked in.

-- 
Joel