From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA/testsuite] Remove KFAILs in sep.exp
Date: Wed, 05 May 2004 19:16:00 -0000 [thread overview]
Message-ID: <20040505191615.GN16083@gnat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
Hello,
Now that our dwarf2reader handles included files, the two tests
in sep.exp that used to KFAIL now KPASS. I therefore suggest the
attached patch to remove the setup_kfail on these tests.
I removed the entire machinery that computes the debug format,
since it is no longer useful.
2004-05-05 Joel Brobecker <brobecker@gnat.com>
* gdb.base/sep.exp: No longer setup_kfail when the program was
built with dwarf2.
Tested on x86-linux.
Ok to apply?
Thanks,
--
Joel
[-- Attachment #2: sep.exp.diff --]
[-- Type: text/plain, Size: 1587 bytes --]
Index: gdb.base/sep.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/sep.exp,v
retrieving revision 1.2
diff -u -r1.2 sep.exp
--- gdb.base/sep.exp 12 Apr 2004 20:22:54 -0000 1.2
+++ gdb.base/sep.exp 5 May 2004 19:14:48 -0000
@@ -29,18 +29,6 @@
gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
}
-# Get the debug info format, using the get_debug_format.
-# Note that the function above needs the current source file to be set,
-# so we need to send a dummy command first which side effect is to set
-# the current source file.
-gdb_exit
-gdb_start
-gdb_load ${binfile}
-gdb_test "list sep.c:1" ".*" "dummy command to set the current source file"
-get_debug_format
-
-# We need to restart the debugger, because the method used to compute
-# the debug format (above) affects this testcase.
gdb_exit
gdb_start
gdb_reinitialize_dir $srcdir/$subdir
@@ -56,10 +44,6 @@
# say_hello is good enough, and avoid unnecessary failures is someone
# decides later to reformat sep-proc.c.
-if { [test_debug_format "DWARF 2"] } then {
- setup_kfail "symtab/1607" *-*-*
-}
-
gdb_test "list sep-proc.c:23" \
"void.*say_hello.*" \
"list using location inside included file"
@@ -71,10 +55,6 @@
gdb_start
gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}
-
-if { [test_debug_format "DWARF 2"] } then {
- setup_kfail "symtab/1607" *-*-*
-}
set test "breakpoint inside included file"
gdb_test_multiple "break sep-proc.c:25" "$test" {
next reply other threads:[~2004-05-05 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-05 19:16 Joel Brobecker [this message]
2004-05-06 17:13 ` Jim Blandy
2004-05-06 21:32 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040505191615.GN16083@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox