From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2787 invoked by alias); 5 May 2004 19:16:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2778 invoked from network); 5 May 2004 19:16:15 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 5 May 2004 19:16:15 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 1FE1347D64; Wed, 5 May 2004 12:16:15 -0700 (PDT) Date: Wed, 05 May 2004 19:16:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: [RFA/testsuite] Remove KFAILs in sep.exp Message-ID: <20040505191615.GN16083@gnat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="at6+YcpfzWZg/htY" Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2004-05/txt/msg00144.txt.bz2 --at6+YcpfzWZg/htY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 490 Hello, Now that our dwarf2reader handles included files, the two tests in sep.exp that used to KFAIL now KPASS. I therefore suggest the attached patch to remove the setup_kfail on these tests. I removed the entire machinery that computes the debug format, since it is no longer useful. 2004-05-05 Joel Brobecker * gdb.base/sep.exp: No longer setup_kfail when the program was built with dwarf2. Tested on x86-linux. Ok to apply? Thanks, -- Joel --at6+YcpfzWZg/htY Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="sep.exp.diff" Content-length: 1587 Index: gdb.base/sep.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/sep.exp,v retrieving revision 1.2 diff -u -r1.2 sep.exp --- gdb.base/sep.exp 12 Apr 2004 20:22:54 -0000 1.2 +++ gdb.base/sep.exp 5 May 2004 19:14:48 -0000 @@ -29,18 +29,6 @@ gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." } -# Get the debug info format, using the get_debug_format. -# Note that the function above needs the current source file to be set, -# so we need to send a dummy command first which side effect is to set -# the current source file. -gdb_exit -gdb_start -gdb_load ${binfile} -gdb_test "list sep.c:1" ".*" "dummy command to set the current source file" -get_debug_format - -# We need to restart the debugger, because the method used to compute -# the debug format (above) affects this testcase. gdb_exit gdb_start gdb_reinitialize_dir $srcdir/$subdir @@ -56,10 +44,6 @@ # say_hello is good enough, and avoid unnecessary failures is someone # decides later to reformat sep-proc.c. -if { [test_debug_format "DWARF 2"] } then { - setup_kfail "symtab/1607" *-*-* -} - gdb_test "list sep-proc.c:23" \ "void.*say_hello.*" \ "list using location inside included file" @@ -71,10 +55,6 @@ gdb_start gdb_reinitialize_dir $srcdir/$subdir gdb_load ${binfile} - -if { [test_debug_format "DWARF 2"] } then { - setup_kfail "symtab/1607" *-*-* -} set test "breakpoint inside included file" gdb_test_multiple "break sep-proc.c:25" "$test" { --at6+YcpfzWZg/htY--