Re: [PATCH] Accept DWARF 3-format debug info

[Jim Blandy <jimb@codesourcery.com>]

Mark Kettenis <mark.kettenis@xs4all.nl> writes:
>> Date: Thu, 8 Jun 2006 19:59:12 -0400
>> From: Daniel Jacobowitz <dan@codesourcery.com>
>> 
>> On Thu, Jun 08, 2006 at 04:25:42PM -0700, Jim Blandy wrote:
>> > I think this patch is right.  It's true that GDB doesn't support all
>> > of DWARF 3, but GDB's general philosophy is to garner as much
>> > information as it can, and punt the rest, which works well with
>> > DWARF's philosophy.  So GDB shouldn't just punt entire compilation
>> > units because they're marked as DWARF 3.
>> 
>> I agree.
>> 
>> There seems to be one structural change in .debug_info tied to the
>> version number (there's also the initial lengths, but we already
>> support that).  That is:
>> 
>> References that use the attribute form DW_FORM_ref_addr are specified
>> to be four bytes in the DWARF 32-bit format and eight bytes in the
>> DWARF 64-bit format, while DWARF Version 2 specifies that such
>> references have the same size as anaddress on the target system (see
>> Sections 7.4 and 7.5.4).
>> 
>> I see two places (skip_one_die and read_attribute_value) that are
>> affected.  So, this should be an easy item to fix.
>
> If this hasn't been fixed yet, could you add appropriate FIXME's at
> those places?  Might save us some time tracking down bugs in the
> future.

I have a patch; I just haven't gotten to running a regression test.
It's pretty trivial.