From: Daniel Jacobowitz <drow@false.org>
To: Jim Blandy <jimb@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: Support DW_FORM_ref_addr as described in DWARF 3
Date: Wed, 12 Jul 2006 21:21:00 -0000 [thread overview]
Message-ID: <20060712212125.GX24622@nevyn.them.org> (raw)
In-Reply-To: <vt264ivli2p.fsf_-_@theseus.home.>
On Tue, Jun 20, 2006 at 12:53:34PM -0700, Jim Blandy wrote:
> Here's a patch for this, as promised; how does it look?
Mostly OK. One typo:
> @@ -2224,7 +2246,7 @@ skip_one_die (gdb_byte *info_ptr, struct
> {
> case DW_FORM_addr:
> case DW_FORM_ref_addr:
> - info_ptr += cu->header.addr_size;
> + info_ptr += cu->header.ref_addr_size;
> break;
> case DW_FORM_data1:
> case DW_FORM_ref1:
> @@ -5733,7 +5755,7 @@ read_attribute_value (struct attribute *
> {
> case DW_FORM_addr:
> case DW_FORM_ref_addr:
> - DW_ADDR (attr) = read_address (abfd, info_ptr, cu, &bytes_read);
> + DW_ADDR (attr) = read_ref_addr (abfd, info_ptr, &cu->header, &bytes_read);
> info_ptr += bytes_read;
> break;
> case DW_FORM_block2:
I don't think you want to use read_ref_addr for DW_FORM_addr.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-07-12 21:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-08 22:48 [PATCH] Accept DWARF 3-format debug info Julian Brown
2006-06-08 23:25 ` Jim Blandy
2006-06-08 23:59 ` Daniel Jacobowitz
2006-06-18 1:10 ` Mark Kettenis
2006-06-18 4:40 ` Jim Blandy
2006-06-20 19:53 ` RFC: Support DW_FORM_ref_addr as described in DWARF 3 Jim Blandy
2006-07-12 21:21 ` Daniel Jacobowitz [this message]
2006-06-09 7:29 ` [PATCH] Accept DWARF 3-format debug info Eli Zaretskii
2006-06-09 12:25 ` Daniel Jacobowitz
2006-06-09 16:42 ` Eli Zaretskii
2006-06-09 17:20 ` Daniel Jacobowitz
2006-06-09 19:46 ` Eli Zaretskii
2006-06-09 12:39 ` Julian Brown
2006-06-09 16:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060712212125.GX24622@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=jimb@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox