From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28104 invoked by alias); 12 Jul 2006 21:21:29 -0000 Received: (qmail 28096 invoked by uid 22791); 12 Jul 2006 21:21:28 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 12 Jul 2006 21:21:27 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G0m97-00008J-1Z; Wed, 12 Jul 2006 17:21:25 -0400 Date: Wed, 12 Jul 2006 21:21:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: gdb-patches@sourceware.org Subject: Re: RFC: Support DW_FORM_ref_addr as described in DWARF 3 Message-ID: <20060712212125.GX24622@nevyn.them.org> Mail-Followup-To: Jim Blandy , gdb-patches@sourceware.org References: <4488A920.9090705@codesourcery.com> <20060608235912.GA6545@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00136.txt.bz2 On Tue, Jun 20, 2006 at 12:53:34PM -0700, Jim Blandy wrote: > Here's a patch for this, as promised; how does it look? Mostly OK. One typo: > @@ -2224,7 +2246,7 @@ skip_one_die (gdb_byte *info_ptr, struct > { > case DW_FORM_addr: > case DW_FORM_ref_addr: > - info_ptr += cu->header.addr_size; > + info_ptr += cu->header.ref_addr_size; > break; > case DW_FORM_data1: > case DW_FORM_ref1: > @@ -5733,7 +5755,7 @@ read_attribute_value (struct attribute * > { > case DW_FORM_addr: > case DW_FORM_ref_addr: > - DW_ADDR (attr) = read_address (abfd, info_ptr, cu, &bytes_read); > + DW_ADDR (attr) = read_ref_addr (abfd, info_ptr, &cu->header, &bytes_read); > info_ptr += bytes_read; > break; > case DW_FORM_block2: I don't think you want to use read_ref_addr for DW_FORM_addr. -- Daniel Jacobowitz CodeSourcery