Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: dan@codesourcery.com
Cc: jimb@codesourcery.com, julian@codesourcery.com,
	gdb-patches@sourceware.org
Subject: Re: [PATCH] Accept DWARF 3-format debug info
Date: Sun, 18 Jun 2006 01:10:00 -0000	[thread overview]
Message-ID: <200606180108.k5I18ofB017579@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20060608235912.GA6545@nevyn.them.org> (message from Daniel 	Jacobowitz on Thu, 8 Jun 2006 19:59:12 -0400)

> Date: Thu, 8 Jun 2006 19:59:12 -0400
> From: Daniel Jacobowitz <dan@codesourcery.com>
> 
> On Thu, Jun 08, 2006 at 04:25:42PM -0700, Jim Blandy wrote:
> > I think this patch is right.  It's true that GDB doesn't support all
> > of DWARF 3, but GDB's general philosophy is to garner as much
> > information as it can, and punt the rest, which works well with
> > DWARF's philosophy.  So GDB shouldn't just punt entire compilation
> > units because they're marked as DWARF 3.
> 
> I agree.
> 
> There seems to be one structural change in .debug_info tied to the
> version number (there's also the initial lengths, but we already
> support that).  That is:
> 
> References that use the attribute form DW_FORM_ref_addr are specified
> to be four bytes in the DWARF 32-bit format and eight bytes in the
> DWARF 64-bit format, while DWARF Version 2 specifies that such
> references have the same size as anaddress on the target system (see
> Sections 7.4 and 7.5.4).
> 
> I see two places (skip_one_die and read_attribute_value) that are
> affected.  So, this should be an easy item to fix.

If this hasn't been fixed yet, could you add appropriate FIXME's at
those places?  Might save us some time tracking down bugs in the
future.

Mark


  reply	other threads:[~2006-06-18  1:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-08 22:48 Julian Brown
2006-06-08 23:25 ` Jim Blandy
2006-06-08 23:59   ` Daniel Jacobowitz
2006-06-18  1:10     ` Mark Kettenis [this message]
2006-06-18  4:40       ` Jim Blandy
2006-06-20 19:53     ` RFC: Support DW_FORM_ref_addr as described in DWARF 3 Jim Blandy
2006-07-12 21:21       ` Daniel Jacobowitz
2006-06-09  7:29   ` [PATCH] Accept DWARF 3-format debug info Eli Zaretskii
2006-06-09 12:25     ` Daniel Jacobowitz
2006-06-09 16:42       ` Eli Zaretskii
2006-06-09 17:20         ` Daniel Jacobowitz
2006-06-09 19:46           ` Eli Zaretskii
2006-06-09 12:39     ` Julian Brown
2006-06-09 16:39       ` Eli Zaretskii
2006-06-09 23:18 David Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606180108.k5I18ofB017579@elgar.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jimb@codesourcery.com \
    --cc=julian@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox