From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6962 invoked by alias); 18 Jun 2006 01:10:18 -0000 Received: (qmail 6954 invoked by uid 22791); 18 Jun 2006 01:10:17 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 18 Jun 2006 01:10:14 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k5I18pRH020983; Sun, 18 Jun 2006 03:08:51 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k5I18ohK018334; Sun, 18 Jun 2006 03:08:51 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k5I18ofB017579; Sun, 18 Jun 2006 03:08:50 +0200 (CEST) Date: Sun, 18 Jun 2006 01:10:00 -0000 Message-Id: <200606180108.k5I18ofB017579@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: dan@codesourcery.com CC: jimb@codesourcery.com, julian@codesourcery.com, gdb-patches@sourceware.org In-reply-to: <20060608235912.GA6545@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 8 Jun 2006 19:59:12 -0400) Subject: Re: [PATCH] Accept DWARF 3-format debug info References: <4488A920.9090705@codesourcery.com> <20060608235912.GA6545@nevyn.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00249.txt.bz2 > Date: Thu, 8 Jun 2006 19:59:12 -0400 > From: Daniel Jacobowitz > > On Thu, Jun 08, 2006 at 04:25:42PM -0700, Jim Blandy wrote: > > I think this patch is right. It's true that GDB doesn't support all > > of DWARF 3, but GDB's general philosophy is to garner as much > > information as it can, and punt the rest, which works well with > > DWARF's philosophy. So GDB shouldn't just punt entire compilation > > units because they're marked as DWARF 3. > > I agree. > > There seems to be one structural change in .debug_info tied to the > version number (there's also the initial lengths, but we already > support that). That is: > > References that use the attribute form DW_FORM_ref_addr are specified > to be four bytes in the DWARF 32-bit format and eight bytes in the > DWARF 64-bit format, while DWARF Version 2 specifies that such > references have the same size as anaddress on the target system (see > Sections 7.4 and 7.5.4). > > I see two places (skip_one_die and read_attribute_value) that are > affected. So, this should be an easy item to fix. If this hasn't been fixed yet, could you add appropriate FIXME's at those places? Might save us some time tracking down bugs in the future. Mark