From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16006 invoked by alias); 18 Jun 2006 04:40:40 -0000 Received: (qmail 15997 invoked by uid 22791); 18 Jun 2006 04:40:39 -0000 X-Spam-Check-By: sourceware.org Received: from potter.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 18 Jun 2006 04:40:37 +0000 Received: (qmail 2088 invoked from network); 18 Jun 2006 04:40:35 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 Jun 2006 04:40:35 -0000 To: Mark Kettenis Cc: dan@codesourcery.com, julian@codesourcery.com, gdb-patches@sourceware.org Subject: Re: [PATCH] Accept DWARF 3-format debug info References: <4488A920.9090705@codesourcery.com> <20060608235912.GA6545@nevyn.them.org> <200606180108.k5I18ofB017579@elgar.sibelius.xs4all.nl> From: Jim Blandy Date: Sun, 18 Jun 2006 04:40:00 -0000 In-Reply-To: <200606180108.k5I18ofB017579@elgar.sibelius.xs4all.nl> (Mark Kettenis's message of "Sun, 18 Jun 2006 03:08:50 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00253.txt.bz2 Mark Kettenis writes: >> Date: Thu, 8 Jun 2006 19:59:12 -0400 >> From: Daniel Jacobowitz >> >> On Thu, Jun 08, 2006 at 04:25:42PM -0700, Jim Blandy wrote: >> > I think this patch is right. It's true that GDB doesn't support all >> > of DWARF 3, but GDB's general philosophy is to garner as much >> > information as it can, and punt the rest, which works well with >> > DWARF's philosophy. So GDB shouldn't just punt entire compilation >> > units because they're marked as DWARF 3. >> >> I agree. >> >> There seems to be one structural change in .debug_info tied to the >> version number (there's also the initial lengths, but we already >> support that). That is: >> >> References that use the attribute form DW_FORM_ref_addr are specified >> to be four bytes in the DWARF 32-bit format and eight bytes in the >> DWARF 64-bit format, while DWARF Version 2 specifies that such >> references have the same size as anaddress on the target system (see >> Sections 7.4 and 7.5.4). >> >> I see two places (skip_one_die and read_attribute_value) that are >> affected. So, this should be an easy item to fix. > > If this hasn't been fixed yet, could you add appropriate FIXME's at > those places? Might save us some time tracking down bugs in the > future. I have a patch; I just haven't gotten to running a regression test. It's pretty trivial.