From: Jim Blandy <jimb@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] parse and eval breakpoint conditions with correct language
Date: Thu, 11 Sep 2003 22:20:00 -0000 [thread overview]
Message-ID: <vt2ekynnf3e.fsf@zenia.home> (raw)
In-Reply-To: <20030911180920.GD945@gnat.com>
I think the correct behavior is to always re-parse the breakpoint in
the same language it was parsed with the first time. If the user
liked how the breakpoint was interpreted the first time, then that's
what they meant.
We try to record that language in b->language, and
breakpoint_re_set_one tries to make sure that's the language used, by
calling set_language before re-parsing the breakpoint's line spec.
But the bug, it seems to me, is that breakpoint_re_set_one should also
set language_mode to language_mode_manual for that call to
decode_line_1, since it doesn't want any language_mode_auto-ish
language inference to mess things up. That's what's happening now, if
I understand the misbehavior you've described.
Of course, the mode must be language_mode_auto when we re-parse any
breakpoint condition expressions or watchpoint expressions. Both of
those expressions have blocks to use for context, and we want to use
their languages.
prev parent reply other threads:[~2003-09-11 22:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-10 1:54 Joel Brobecker
2003-09-10 17:31 ` Jim Blandy
2003-09-11 18:09 ` Joel Brobecker
2003-09-11 18:42 ` Paul Koning
2003-09-11 19:30 ` Joel Brobecker
2003-09-12 1:33 ` Andrew Cagney
2003-09-12 5:46 ` Joel Brobecker
2003-09-15 3:09 ` Jim Blandy
2003-09-15 19:00 ` Joel Brobecker
2003-09-11 19:20 ` Andrew Cagney
2003-09-11 19:32 ` Joel Brobecker
2003-09-11 19:54 ` Daniel Jacobowitz
2003-09-11 22:20 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt2ekynnf3e.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox