From: Jim Blandy <jimb@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: Andrew Cagney <ac131313@redhat.com>,
Paul Koning <pkoning@equallogic.com>,
gdb-patches@sources.redhat.com
Subject: Re: [RFA] parse and eval breakpoint conditions with correct language
Date: Mon, 15 Sep 2003 03:09:00 -0000 [thread overview]
Message-ID: <vt21xuin41l.fsf@zenia.home> (raw)
In-Reply-To: <20030912054651.GI945@gnat.com>
Joel Brobecker <brobecker@gnat.com> writes:
> > BTW, this setting of the global current_language all also worries me :-)
> > Should parse_expression take an explict language?
>
> Me too, actually. I think passing the langauge to parse_expression et al
> is a good idea. It's more work, but seems more manageable than using a
> couple of global variables.
>
> Jim, what do you think?
Definitely. Mucking around with globals just to keep something from
throwing away information you've got right at hand is pretty
indicative.
What gives me pause, though, is that the breakpoint_re_set_one isn't
calling parse_exp_1 directly --- it's calling decode_line_1. Are you
going to propagate the language all the way through there? How do you
see approaching this?
next prev parent reply other threads:[~2003-09-15 3:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-10 1:54 Joel Brobecker
2003-09-10 17:31 ` Jim Blandy
2003-09-11 18:09 ` Joel Brobecker
2003-09-11 18:42 ` Paul Koning
2003-09-11 19:30 ` Joel Brobecker
2003-09-12 1:33 ` Andrew Cagney
2003-09-12 5:46 ` Joel Brobecker
2003-09-15 3:09 ` Jim Blandy [this message]
2003-09-15 19:00 ` Joel Brobecker
2003-09-11 19:20 ` Andrew Cagney
2003-09-11 19:32 ` Joel Brobecker
2003-09-11 19:54 ` Daniel Jacobowitz
2003-09-11 22:20 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt21xuin41l.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=ac131313@redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=pkoning@equallogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox