From: Andrew Cagney <ac131313@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: Paul Koning <pkoning@equallogic.com>,
jimb@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA] parse and eval breakpoint conditions with correct language
Date: Fri, 12 Sep 2003 01:33:00 -0000 [thread overview]
Message-ID: <3F612249.7060102@redhat.com> (raw)
In-Reply-To: <20030911192958.GE945@gnat.com>
> The following patch seems to be fixing it, but I would need more
> time to really think about it more thouroughly.
>
> --- breakpoint.c 5 Sep 2003 21:51:24 -0000 1.4
> +++ breakpoint.c 11 Sep 2003 19:23:08 -0000
> @@ -7089,6 +7089,7 @@ breakpoint_re_set_one (PTR bint)
> /* So for now, just use a global context. */
> if (b->exp)
> xfree (b->exp);
> + set_language (b->language);
> b->exp = parse_expression (b->exp_string);
> b->exp_valid_block = innermost_block;
> mark = value_mark ();
BTW, this setting of the global current_language all also worries me :-)
Should parse_expression take an explict language?
Andrew
next prev parent reply other threads:[~2003-09-12 1:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-10 1:54 Joel Brobecker
2003-09-10 17:31 ` Jim Blandy
2003-09-11 18:09 ` Joel Brobecker
2003-09-11 18:42 ` Paul Koning
2003-09-11 19:30 ` Joel Brobecker
2003-09-12 1:33 ` Andrew Cagney [this message]
2003-09-12 5:46 ` Joel Brobecker
2003-09-15 3:09 ` Jim Blandy
2003-09-15 19:00 ` Joel Brobecker
2003-09-11 19:20 ` Andrew Cagney
2003-09-11 19:32 ` Joel Brobecker
2003-09-11 19:54 ` Daniel Jacobowitz
2003-09-11 22:20 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F612249.7060102@redhat.com \
--to=ac131313@redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
--cc=pkoning@equallogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox