From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32012 invoked by alias); 12 Sep 2003 01:33:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32001 invoked from network); 12 Sep 2003 01:33:00 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 12 Sep 2003 01:33:00 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id D207E2B89; Thu, 11 Sep 2003 21:32:57 -0400 (EDT) Message-ID: <3F612249.7060102@redhat.com> Date: Fri, 12 Sep 2003 01:33:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker Cc: Paul Koning , jimb@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [RFA] parse and eval breakpoint conditions with correct language References: <20030910015400.GS423@gnat.com> <20030911180920.GD945@gnat.com> <16224.49692.542476.869174@gargle.gargle.HOWL> <20030911192958.GE945@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-09/txt/msg00257.txt.bz2 > The following patch seems to be fixing it, but I would need more > time to really think about it more thouroughly. > > --- breakpoint.c 5 Sep 2003 21:51:24 -0000 1.4 > +++ breakpoint.c 11 Sep 2003 19:23:08 -0000 > @@ -7089,6 +7089,7 @@ breakpoint_re_set_one (PTR bint) > /* So for now, just use a global context. */ > if (b->exp) > xfree (b->exp); > + set_language (b->language); > b->exp = parse_expression (b->exp_string); > b->exp_valid_block = innermost_block; > mark = value_mark (); BTW, this setting of the global current_language all also worries me :-) Should parse_expression take an explict language? Andrew