From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1006 invoked by alias); 15 Sep 2003 03:09:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 994 invoked from network); 15 Sep 2003 03:08:59 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 15 Sep 2003 03:08:59 -0000 Received: by zenia.home (Postfix, from userid 5433) id 7A72C20758; Sun, 14 Sep 2003 22:06:46 -0500 (EST) To: Joel Brobecker Cc: Andrew Cagney , Paul Koning , gdb-patches@sources.redhat.com Subject: Re: [RFA] parse and eval breakpoint conditions with correct language References: <20030910015400.GS423@gnat.com> <20030911180920.GD945@gnat.com> <16224.49692.542476.869174@gargle.gargle.HOWL> <20030911192958.GE945@gnat.com> <3F612249.7060102@redhat.com> <20030912054651.GI945@gnat.com> From: Jim Blandy Date: Mon, 15 Sep 2003 03:09:00 -0000 In-Reply-To: <20030912054651.GI945@gnat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-09/txt/msg00321.txt.bz2 Joel Brobecker writes: > > BTW, this setting of the global current_language all also worries me :-) > > Should parse_expression take an explict language? > > Me too, actually. I think passing the langauge to parse_expression et al > is a good idea. It's more work, but seems more manageable than using a > couple of global variables. > > Jim, what do you think? Definitely. Mucking around with globals just to keep something from throwing away information you've got right at hand is pretty indicative. What gives me pause, though, is that the breakpoint_re_set_one isn't calling parse_exp_1 directly --- it's calling decode_line_1. Are you going to propagate the language all the way through there? How do you see approaching this?