From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7406 invoked by alias); 11 Sep 2003 22:20:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7399 invoked from network); 11 Sep 2003 22:20:49 -0000 Received: from unknown (HELO zenia.home) (12.223.225.216) by sources.redhat.com with SMTP; 11 Sep 2003 22:20:49 -0000 Received: by zenia.home (Postfix, from userid 5433) id 7D0A0206DF; Thu, 11 Sep 2003 17:19:01 -0500 (EST) To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] parse and eval breakpoint conditions with correct language References: <20030910015400.GS423@gnat.com> <20030911180920.GD945@gnat.com> From: Jim Blandy Date: Thu, 11 Sep 2003 22:20:00 -0000 In-Reply-To: <20030911180920.GD945@gnat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-09/txt/msg00251.txt.bz2 I think the correct behavior is to always re-parse the breakpoint in the same language it was parsed with the first time. If the user liked how the breakpoint was interpreted the first time, then that's what they meant. We try to record that language in b->language, and breakpoint_re_set_one tries to make sure that's the language used, by calling set_language before re-parsing the breakpoint's line spec. But the bug, it seems to me, is that breakpoint_re_set_one should also set language_mode to language_mode_manual for that call to decode_line_1, since it doesn't want any language_mode_auto-ish language inference to mess things up. That's what's happening now, if I understand the misbehavior you've described. Of course, the mode must be language_mode_auto when we re-parse any breakpoint condition expressions or watchpoint expressions. Both of those expressions have blocks to use for context, and we want to use their languages.