Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: tromey@redhat.com, gdb-patches@sources.redhat.com,
	nickrob@snap.net.nz, marc.khouzam@ericsson.com
Subject: Re: [RFA] fix *stopped for CLI commands
Date: Thu, 12 Feb 2009 20:37:00 -0000	[thread overview]
Message-ID: <uzlgrwg5o.fsf@gnu.org> (raw)
In-Reply-To: <200902121146.00168.vladimir@codesourcery.com>

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Thu, 12 Feb 2009 11:45:59 +0300
> Cc: gdb-patches@sources.redhat.com,
>  Nick Roberts <nickrob@snap.net.nz>,
>  Marc Khouzam <marc.khouzam@ericsson.com>
> 
> The attached patch does so. Eli, can you see if the doc change is fine?

Fine, but I have some comments:

> +@deftypefun void normal_stop (struct bpstats *@var{bs}, int @var{print_frame})
> +The inferior has stopped for real.  The  @var{bs} parameter describes
                                                     ^^^^^^^^^
I think we should use "argument", not "parameter" here.

>                                                 The @var{print_frame}
> +parameter indicates whether the @value{GDBN} core suggests that the
> +location where the inferiour has stopped is known and should be
> +reported to the user.

That's a mouthful: too many passive tenses.  How about this variant:

  Second argument @var{print_frame} non-zero means display the
  location where the inferior has stopped.

("inferior", not "inferiour" because we use the US English spelling)

> +	  /* The normal_stop function has printed frame information into 
> +	     CLI uiout, or some other non-MI uiout.  There's no way we
> +	     can extra proper fields from random uiout object, so we print
                 ^^^^^
Did you mean "extract"?

Thanks.


  reply	other threads:[~2009-02-12 20:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-06  7:44 Vladimir Prus
2009-02-06 21:11 ` Tom Tromey
2009-02-07  1:04   ` Joel Brobecker
2009-02-12  8:46   ` Vladimir Prus
2009-02-12 20:37     ` Eli Zaretskii [this message]
2009-02-14 20:43       ` Vladimir Prus
2009-02-15 18:22         ` Pedro Alves
2009-02-17 19:25           ` Vladimir Prus
2009-02-17 19:29             ` Pedro Alves
2009-02-09 20:36 ` Daniel Jacobowitz
2009-02-10 20:50 ` Marc Khouzam
2009-02-10 20:58   ` Vladimir Prus
2009-02-11 14:09     ` Marc Khouzam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uzlgrwg5o.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=marc.khouzam@ericsson.com \
    --cc=nickrob@snap.net.nz \
    --cc=tromey@redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox