Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Vladimir Prus <vladimir@codesourcery.com>,
		gdb-patches@sources.redhat.com,
	Nick Roberts <nickrob@snap.net.nz>,
		Marc Khouzam <marc.khouzam@ericsson.com>
Subject: Re: [RFA] fix *stopped for CLI commands
Date: Sat, 07 Feb 2009 01:04:00 -0000	[thread overview]
Message-ID: <20090207010415.GF3676@adacore.com> (raw)
In-Reply-To: <m34oz75kzk.fsf@fleche.redhat.com>

> Vladimir> This patch fixes this by making MI observer print frame
> Vladimir> again, into MI uiout, if necessary. It passes all MI tests
> Vladimir> in (sync,async)x(native,gdbserver) combinations.  How does
> Vladimir> this look, and are non-MI changes OK? If approved, I'll add
> Vladimir> a test that CLI commands result in proper *stopped.
> 
> I don't understand all the implications of the core change, but I do
> like how it moves some MI logic out of the core and into MI.

Agreed. Ideally, I'd really like to see all such notifications
be handled by observers, even the CLI ones.

-- 
Joel


  reply	other threads:[~2009-02-07  1:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-06  7:44 Vladimir Prus
2009-02-06 21:11 ` Tom Tromey
2009-02-07  1:04   ` Joel Brobecker [this message]
2009-02-12  8:46   ` Vladimir Prus
2009-02-12 20:37     ` Eli Zaretskii
2009-02-14 20:43       ` Vladimir Prus
2009-02-15 18:22         ` Pedro Alves
2009-02-17 19:25           ` Vladimir Prus
2009-02-17 19:29             ` Pedro Alves
2009-02-09 20:36 ` Daniel Jacobowitz
2009-02-10 20:50 ` Marc Khouzam
2009-02-10 20:58   ` Vladimir Prus
2009-02-11 14:09     ` Marc Khouzam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090207010415.GF3676@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=marc.khouzam@ericsson.com \
    --cc=nickrob@snap.net.nz \
    --cc=tromey@redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox