Re: [RFA] fix *stopped for CLI commands

[Vladimir Prus <vladimir@codesourcery.com>]

On Thursday 12 February 2009 23:31:47 Eli Zaretskii wrote:
> > From: Vladimir Prus <vladimir@codesourcery.com>
> > Date: Thu, 12 Feb 2009 11:45:59 +0300
> > Cc: gdb-patches@sources.redhat.com,
> >  Nick Roberts <nickrob@snap.net.nz>,
> >  Marc Khouzam <marc.khouzam@ericsson.com>
> > 
> > The attached patch does so. Eli, can you see if the doc change is fine?
> 
> Fine, but I have some comments:
> 
> > +@deftypefun void normal_stop (struct bpstats *@var{bs}, int @var{print_frame})
> > +The inferior has stopped for real.  The  @var{bs} parameter describes
>                                                      ^^^^^^^^^
> I think we should use "argument", not "parameter" here.
> 
> >                                                 The @var{print_frame}
> > +parameter indicates whether the @value{GDBN} core suggests that the
> > +location where the inferiour has stopped is known and should be
> > +reported to the user.
> 
> That's a mouthful: too many passive tenses.  How about this variant:
> 
>   Second argument @var{print_frame} non-zero means display the
>   location where the inferior has stopped.
> 
> ("inferior", not "inferiour" because we use the US English spelling)
> 
> > +	  /* The normal_stop function has printed frame information into 
> > +	     CLI uiout, or some other non-MI uiout.  There's no way we
> > +	     can extra proper fields from random uiout object, so we print
>                  ^^^^^
> Did you mean "extract"?

Thanks,
I have checked in this patch with the corrections you've suggested.

- Volodya