From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28351 invoked by alias); 14 Feb 2009 19:22:44 -0000 Received: (qmail 28342 invoked by uid 22791); 14 Feb 2009 19:22:43 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 14 Feb 2009 19:22:37 +0000 Received: (qmail 13374 invoked from network); 14 Feb 2009 19:22:35 -0000 Received: from unknown (HELO wind.local) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Feb 2009 19:22:35 -0000 From: Vladimir Prus To: Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: [RFA] fix *stopped for CLI commands Date: Sat, 14 Feb 2009 20:43:00 -0000 User-Agent: KMail/1.9.10 References: <200902061045.18508.vladimir@codesourcery.com> <200902121146.00168.vladimir@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902142222.31325.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00323.txt.bz2 On Thursday 12 February 2009 23:31:47 Eli Zaretskii wrote: > > From: Vladimir Prus > > Date: Thu, 12 Feb 2009 11:45:59 +0300 > > Cc: gdb-patches@sources.redhat.com, > > Nick Roberts , > > Marc Khouzam > > > > The attached patch does so. Eli, can you see if the doc change is fine? > > Fine, but I have some comments: > > > +@deftypefun void normal_stop (struct bpstats *@var{bs}, int @var{print_frame}) > > +The inferior has stopped for real. The @var{bs} parameter describes > ^^^^^^^^^ > I think we should use "argument", not "parameter" here. > > > The @var{print_frame} > > +parameter indicates whether the @value{GDBN} core suggests that the > > +location where the inferiour has stopped is known and should be > > +reported to the user. > > That's a mouthful: too many passive tenses. How about this variant: > > Second argument @var{print_frame} non-zero means display the > location where the inferior has stopped. > > ("inferior", not "inferiour" because we use the US English spelling) > > > + /* The normal_stop function has printed frame information into > > + CLI uiout, or some other non-MI uiout. There's no way we > > + can extra proper fields from random uiout object, so we print > ^^^^^ > Did you mean "extract"? Thanks, I have checked in this patch with the corrections you've suggested. - Volodya