From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13823 invoked by alias); 12 Feb 2009 20:32:01 -0000 Received: (qmail 13809 invoked by uid 22791); 12 Feb 2009 20:32:00 -0000 X-SWARE-Spam-Status: No, hits=1.0 required=5.0 tests=AWL,BAYES_00,BOTNET,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Feb 2009 20:31:49 +0000 Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KEY00400ZMXHD00@i-mtaout1.012.net.il> for gdb-patches@sources.redhat.com; Thu, 12 Feb 2009 22:32:15 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.24.112]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KEY00BQXZPPAY40@i-mtaout1.012.net.il>; Thu, 12 Feb 2009 22:32:14 +0200 (IST) Date: Thu, 12 Feb 2009 20:37:00 -0000 From: Eli Zaretskii Subject: Re: [RFA] fix *stopped for CLI commands In-reply-to: <200902121146.00168.vladimir@codesourcery.com> To: Vladimir Prus Cc: tromey@redhat.com, gdb-patches@sources.redhat.com, nickrob@snap.net.nz, marc.khouzam@ericsson.com Reply-to: Eli Zaretskii Message-id: References: <200902061045.18508.vladimir@codesourcery.com> <200902121146.00168.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00297.txt.bz2 > From: Vladimir Prus > Date: Thu, 12 Feb 2009 11:45:59 +0300 > Cc: gdb-patches@sources.redhat.com, > Nick Roberts , > Marc Khouzam > > The attached patch does so. Eli, can you see if the doc change is fine? Fine, but I have some comments: > +@deftypefun void normal_stop (struct bpstats *@var{bs}, int @var{print_frame}) > +The inferior has stopped for real. The @var{bs} parameter describes ^^^^^^^^^ I think we should use "argument", not "parameter" here. > The @var{print_frame} > +parameter indicates whether the @value{GDBN} core suggests that the > +location where the inferiour has stopped is known and should be > +reported to the user. That's a mouthful: too many passive tenses. How about this variant: Second argument @var{print_frame} non-zero means display the location where the inferior has stopped. ("inferior", not "inferiour" because we use the US English spelling) > + /* The normal_stop function has printed frame information into > + CLI uiout, or some other non-MI uiout. There's no way we > + can extra proper fields from random uiout object, so we print ^^^^^ Did you mean "extract"? Thanks.