From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sourceware.org, Charles Wilson <cygwin@cwilson.fastmail.fm>
Subject: Re: RFA: ensure binary objects opened in binary mode
Date: Sat, 18 Feb 2006 10:45:00 -0000 [thread overview]
Message-ID: <uy809eyin.fsf@gnu.org> (raw)
In-Reply-To: <20060217234141.GA1918@trixie.casa.cgf.cx> (message from Christopher Faylor on Fri, 17 Feb 2006 18:41:41 -0500)
> Date: Fri, 17 Feb 2006 18:41:41 -0500
> From: Christopher Faylor <cgf-please-use-the-mailinglist@sourceware.org>
>
> On Fri, Feb 17, 2006 at 04:59:27PM -0500, Charles Wilson wrote:
> >2006-02-17 Charles Wilson <...>
> >
> > * gdb/solib.c(solib_open): ensure solib files are opened in
> > binary mode.
>
> I think this patch is a good idea but I'm wondering if we're doing the
>
> #ifdef O_BINARY
> # define O_BINARY 0
> #endif
>
> trick in too many source files. Maybe it's time for this to be in a header
> file?
Agreed. I think defs.h is a good place, do you agree?
next prev parent reply other threads:[~2006-02-18 10:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-17 22:02 Charles Wilson
2006-02-17 23:41 ` Christopher Faylor
2006-02-18 10:45 ` Eli Zaretskii [this message]
2006-02-18 11:19 ` Mark Kettenis
2006-02-18 11:47 ` Eli Zaretskii
2006-02-18 11:55 ` Mark Kettenis
2006-02-22 5:52 ` Charles Wilson
2006-02-22 17:06 ` Christopher Faylor
2006-02-22 18:50 ` Eli Zaretskii
2006-02-22 21:55 ` Daniel Jacobowitz
2006-02-24 10:37 ` Charles Wilson
2006-02-24 11:44 ` Eli Zaretskii
2006-02-25 7:29 ` Charles Wilson
2006-03-01 22:11 ` Michael Snyder
2006-02-18 10:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uy809eyin.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=cygwin@cwilson.fastmail.fm \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox