Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Charles Wilson <cygwin@cwilson.fastmail.fm>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: ensure binary objects opened in binary mode
Date: Sat, 18 Feb 2006 10:50:00 -0000	[thread overview]
Message-ID: <uwtfteyb4.fsf@gnu.org> (raw)
In-Reply-To: <43F6473F.8030508@cwilson.fastmail.fm> (message from Charles 	Wilson on Fri, 17 Feb 2006 16:59:27 -0500)

> Date: Fri, 17 Feb 2006 16:59:27 -0500
> From: Charles Wilson <cygwin@cwilson.fastmail.fm>
> 
> However, even on cygwin, it's still *wrong* for gdb to open a solib 
> (which is by definition a binary object) in text mode -- even if it gets 
> "fixed" later by bfd_open().  So IMO this patch is "the right thing" for 
> both cygwin and mingw, even tho there is no observable change in 
> cygwin's behavior -- and it DOES fix a serious bug on mingw.

This patch is fine with me, but I agree with Chris that the
definitions of O_BINARY should be unified in a header file, and the
definitions private to various *.c files removed.  I suggested defs.h
as the header to put the one definition.

Thanks.


      parent reply	other threads:[~2006-02-18 10:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-17 22:02 Charles Wilson
2006-02-17 23:41 ` Christopher Faylor
2006-02-18 10:45   ` Eli Zaretskii
2006-02-18 11:19     ` Mark Kettenis
2006-02-18 11:47       ` Eli Zaretskii
2006-02-18 11:55         ` Mark Kettenis
2006-02-22  5:52         ` Charles Wilson
2006-02-22 17:06           ` Christopher Faylor
2006-02-22 18:50           ` Eli Zaretskii
2006-02-22 21:55             ` Daniel Jacobowitz
2006-02-24 10:37               ` Charles Wilson
2006-02-24 11:44                 ` Eli Zaretskii
2006-02-25  7:29                   ` Charles Wilson
2006-03-01 22:11             ` Michael Snyder
2006-02-18 10:50 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uwtfteyb4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=cygwin@cwilson.fastmail.fm \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox