From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8366 invoked by alias); 18 Feb 2006 10:50:01 -0000 Received: (qmail 8357 invoked by uid 22791); 18 Feb 2006 10:50:00 -0000 X-Spam-Check-By: sourceware.org Received: from gandalf.inter.net.il (HELO gandalf.inter.net.il) (192.114.186.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 18 Feb 2006 10:49:57 +0000 Received: from nitzan.inter.net.il (nitzan.inter.net.il [192.114.186.20]) by gandalf.inter.net.il (MOS 3.7.1-GA) with ESMTP id HXK02132; Sat, 18 Feb 2006 12:49:52 +0200 (IST) Received: from HOME-C4E4A596F7 (IGLD-84-228-139-42.inter.net.il [84.228.139.42]) by nitzan.inter.net.il (MOS 3.7.3-GA) with ESMTP id CSP61392 (AUTH halo1); Sat, 18 Feb 2006 12:49:51 +0200 (IST) Date: Sat, 18 Feb 2006 10:50:00 -0000 Message-Id: From: Eli Zaretskii To: Charles Wilson CC: gdb-patches@sourceware.org In-reply-to: <43F6473F.8030508@cwilson.fastmail.fm> (message from Charles Wilson on Fri, 17 Feb 2006 16:59:27 -0500) Subject: Re: RFA: ensure binary objects opened in binary mode Reply-to: Eli Zaretskii References: <43F6473F.8030508@cwilson.fastmail.fm> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00344.txt.bz2 > Date: Fri, 17 Feb 2006 16:59:27 -0500 > From: Charles Wilson > > However, even on cygwin, it's still *wrong* for gdb to open a solib > (which is by definition a binary object) in text mode -- even if it gets > "fixed" later by bfd_open(). So IMO this patch is "the right thing" for > both cygwin and mingw, even tho there is no observable change in > cygwin's behavior -- and it DOES fix a serious bug on mingw. This patch is fine with me, but I agree with Chris that the definitions of O_BINARY should be unified in a header file, and the definitions private to various *.c files removed. I suggested defs.h as the header to put the one definition. Thanks.