Re: RFA: ensure binary objects opened in binary mode

[Eli Zaretskii <eliz@gnu.org>]

> Date: Fri, 24 Feb 2006 03:36:02 -0500
> From: Charles Wilson <cygwin@cwilson.fastmail.fm>
> 
> Alrighty then -- here's the next iteration.  Both parts have changed a 
> bit: the first patch no longer removes #include <fcntl.h> from solib.c, 
> while the second patch ONLY addresses the #ifndef O_BINARY clutter and 
> no longer removes <fcntl.h> from the 48 files.
> 
> Patch 1:
>   defs.h  |   12 ++++++++++++
>   solib.c |   12 ++++++------
>   2 files changed, 18 insertions(+), 6 deletions(-)
> 
> 2006-02-24  Charles Wilson  <cygwin@...>
> 
> 	* gdb/defs.h: unconditionally include <fcntl.h>, and
> 	ensure that O_BINARY is defined.
> 	* gdb/solib.c(solib_open): ensure solib files are opened in
> 	binary mode.
> 
> Patch 2:
>   corelow.c    |    3 ---
>   exec.c       |    3 ---
>   remote-rdp.c |    3 ---
>   source.c     |    3 ---
>   symfile.c    |    3 ---
>   5 files changed, 15 deletions(-)
> 
> 2006-02-24  Charles Wilson  <cygwin@...>
> 
> 	* gdb/corelow.c: Remove O_BINARY macro definition.
> 	* gdb/exec.c: Remove O_BINARY macro definition
> 	* gdb/remote-rdp.c: Remove O_BINARY macro definition
> 	* gdb/source.c: Remove O_BINARY macro definition
> 	* gdb/symfile.c: Remove O_BINARY macro definition
> 
> Per cgf's earlier message, I can go ahead and check this in myself 
> assuming everybody's happy with it at this point?

I'm certainly happy.  Thanks!