From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13499 invoked by alias); 24 Feb 2006 10:37:57 -0000 Received: (qmail 13490 invoked by uid 22791); 24 Feb 2006 10:37:56 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Feb 2006 10:37:56 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-52-41.inter.net.il [80.230.52.41]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id DPZ92432 (AUTH halo1); Fri, 24 Feb 2006 12:37:51 +0200 (IST) Date: Fri, 24 Feb 2006 11:44:00 -0000 Message-Id: From: Eli Zaretskii To: Charles Wilson CC: gdb-patches@sourceware.org In-reply-to: <43FEC572.3090403@cwilson.fastmail.fm> (message from Charles Wilson on Fri, 24 Feb 2006 03:36:02 -0500) Subject: Re: RFA: ensure binary objects opened in binary mode Reply-to: Eli Zaretskii References: <43F6473F.8030508@cwilson.fastmail.fm> <20060217234141.GA1918@trixie.casa.cgf.cx> <200602181118.k1IBIwNC028708@elgar.sibelius.xs4all.nl> <43FBF706.9030604@cwilson.fastmail.fm> <20060222185032.GA29383@nevyn.them.org> <43FEC572.3090403@cwilson.fastmail.fm> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00460.txt.bz2 > Date: Fri, 24 Feb 2006 03:36:02 -0500 > From: Charles Wilson > > Alrighty then -- here's the next iteration. Both parts have changed a > bit: the first patch no longer removes #include from solib.c, > while the second patch ONLY addresses the #ifndef O_BINARY clutter and > no longer removes from the 48 files. > > Patch 1: > defs.h | 12 ++++++++++++ > solib.c | 12 ++++++------ > 2 files changed, 18 insertions(+), 6 deletions(-) > > 2006-02-24 Charles Wilson > > * gdb/defs.h: unconditionally include , and > ensure that O_BINARY is defined. > * gdb/solib.c(solib_open): ensure solib files are opened in > binary mode. > > Patch 2: > corelow.c | 3 --- > exec.c | 3 --- > remote-rdp.c | 3 --- > source.c | 3 --- > symfile.c | 3 --- > 5 files changed, 15 deletions(-) > > 2006-02-24 Charles Wilson > > * gdb/corelow.c: Remove O_BINARY macro definition. > * gdb/exec.c: Remove O_BINARY macro definition > * gdb/remote-rdp.c: Remove O_BINARY macro definition > * gdb/source.c: Remove O_BINARY macro definition > * gdb/symfile.c: Remove O_BINARY macro definition > > Per cgf's earlier message, I can go ahead and check this in myself > assuming everybody's happy with it at this point? I'm certainly happy. Thanks!