From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7457 invoked by alias); 18 Feb 2006 10:45:35 -0000 Received: (qmail 7449 invoked by uid 22791); 18 Feb 2006 10:45:35 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 18 Feb 2006 10:45:34 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-228-139-42.inter.net.il [84.228.139.42]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id DOY23524 (AUTH halo1); Sat, 18 Feb 2006 12:45:20 +0200 (IST) Date: Sat, 18 Feb 2006 10:45:00 -0000 Message-Id: From: Eli Zaretskii To: gdb-patches@sourceware.org, Charles Wilson In-reply-to: <20060217234141.GA1918@trixie.casa.cgf.cx> (message from Christopher Faylor on Fri, 17 Feb 2006 18:41:41 -0500) Subject: Re: RFA: ensure binary objects opened in binary mode Reply-to: Eli Zaretskii References: <43F6473F.8030508@cwilson.fastmail.fm> <20060217234141.GA1918@trixie.casa.cgf.cx> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00343.txt.bz2 > Date: Fri, 17 Feb 2006 18:41:41 -0500 > From: Christopher Faylor > > On Fri, Feb 17, 2006 at 04:59:27PM -0500, Charles Wilson wrote: > >2006-02-17 Charles Wilson <...> > > > > * gdb/solib.c(solib_open): ensure solib files are opened in > > binary mode. > > I think this patch is a good idea but I'm wondering if we're doing the > > #ifdef O_BINARY > # define O_BINARY 0 > #endif > > trick in too many source files. Maybe it's time for this to be in a header > file? Agreed. I think defs.h is a good place, do you agree?