Re: [PATCH] Make tracepoints into breakpoints

[Eli Zaretskii <eliz@gnu.org>]

> Date: Fri, 27 Mar 2009 12:22:03 -0700
> From: Stan Shebs <stan@codesourcery.com>
> 
>     doc/
>     * gdb.texinfo (Tracepoints): Describe tracepoints as a
>     special case of breakpoints.
>     (Enable and Disable Tracepoints): Mention deprecation.
>     (Listing Tracepoints): Update description and example.

Thanks.  I have comments about this part:

>   Before running such a @dfn{trace experiment}, an arbitrary number of
> ! tracepoints can be set.  A tracepoint is actually a special type of
> ! breakpoint (@pxref{Set Breaks}), so you can manipulate it using
> ! standard breakpoint commands. For instance, as with breakpoints,
                                ^^
You have numerous places with only one space between sentences.

>   The @code{trace} command is very similar to the @code{break} command.
> ! Its argument @var{location} can be a source line, a function name, or
> ! an address in the target program.  @xref{Set Breaks}.  The
                                       ^^^^^^^^^^^^^^^^^
Please change this cross-reference to point to "Specify Location".

> ! In addition to the basic info common to all types of breakpoints,
> ! tracepoint listings may include a step count, a pass count, and the
> ! list of actions.

In this new text, you have removed the references to the tracepoint
parameters that affect the step count, the passcount, and the actions.
I think we should not drop those references, because they go a long
way towards explaining what these parameters are.

>                     The action lines are prefixed with an @code{A} so

Please use @samp{A} here, not @code{A}.  "A" is not a symbol, so it
should be quoted (in the printed output).

Other than that, the doco part of the patch is OK.