From: Eli Zaretskii <eliz@gnu.org>
To: Stan Shebs <stan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Make tracepoints into breakpoints
Date: Sat, 28 Mar 2009 18:11:00 -0000 [thread overview]
Message-ID: <uwsaakofa.fsf@gnu.org> (raw)
In-Reply-To: <49CD275B.1020003@codesourcery.com>
> Date: Fri, 27 Mar 2009 12:22:03 -0700
> From: Stan Shebs <stan@codesourcery.com>
>
> Here is the long-threatened patch that makes tracepoints into a type of
> breakpoint.
Some calls to printf_filtered have no translation-friendly _() around
their string arguments:
> + ALL_TRACEPOINTS (t2)
> + if (t1 == (struct breakpoint *) -1 || t1 == t2)
> + {
> + t2->pass_count = count;
> + observer_notify_tracepoint_modified (t2->number);
> + if (from_tty)
> + printf_filtered ("Setting tracepoint %d's passcount to %d\n",
> + t2->number, count);
Here.
> + printf_filtered ("bad tracepoint number at or near '%s'\n",
> + instring);
> + else
> + printf_filtered ("Tracepoint argument missing and no previous tracepoint\n");
> + return NULL;
Same here.
> + /* FIXME: if we are in the middle of a range we don't want to give
> + a message. The current interface to get_number_or_range doesn't
> + allow us to discover this. */
> + printf_unfiltered ("No tracepoint number %d.\n", tpnum);
> + return NULL;
And here.
> + if (from_tty)
> + printf_filtered ("Tracepoints saved to file '%s'.\n", args);
> + return;
And here.
next prev parent reply other threads:[~2009-03-28 9:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 19:57 Stan Shebs
2009-03-28 9:07 ` Eli Zaretskii
2009-03-30 16:10 ` Stan Shebs
2009-03-28 18:11 ` Eli Zaretskii [this message]
2009-03-30 15:44 ` Joel Brobecker
2009-03-30 16:56 ` Joel Brobecker
2009-03-30 18:29 ` Stan Shebs
2009-03-30 22:21 ` Joel Brobecker
2009-03-30 23:01 ` Stan Shebs
2009-03-30 22:07 ` Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uwsaakofa.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox