From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-62538-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20978 invoked by alias); 28 Mar 2009 09:07:44 -0000
Received: (qmail 20969 invoked by uid 22791); 28 Mar 2009 09:07:43 -0000
X-SWARE-Spam-Status: No, hits=1.5 required=5.0 	tests=AWL,BAYES_00,BOTNET,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 Mar 2009 09:07:36 +0000
Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KH700N00L821X00@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Sat, 28 Mar 2009 12:07:33 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.127.23.114]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KH7009ZSLCJI790@i-mtaout1.012.net.il>; Sat, 28 Mar 2009 12:07:32 +0300 (IDT)
Date: Sat, 28 Mar 2009 18:11:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Make tracepoints into breakpoints
In-reply-to: <49CD275B.1020003@codesourcery.com>
To: Stan Shebs <stan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <uwsaakofa.fsf@gnu.org>
References: <49CD275B.1020003@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-03/txt/msg00648.txt.bz2

> Date: Fri, 27 Mar 2009 12:22:03 -0700
> From: Stan Shebs <stan@codesourcery.com>
> 
> Here is the long-threatened patch that makes tracepoints into a type of 
> breakpoint.

Some calls to printf_filtered have no translation-friendly _() around
their string arguments:

> + 	  ALL_TRACEPOINTS (t2)
> + 	    if (t1 == (struct breakpoint *) -1 || t1 == t2)
> + 	      {
> + 		t2->pass_count = count;
> + 		observer_notify_tracepoint_modified (t2->number);
> + 		if (from_tty)
> + 		  printf_filtered ("Setting tracepoint %d's passcount to %d\n",
> + 				   t2->number, count);

Here.

> + 	printf_filtered ("bad tracepoint number at or near '%s'\n", 
> + 			 instring);
> +       else
> + 	printf_filtered ("Tracepoint argument missing and no previous tracepoint\n");
> +       return NULL;

Same here.

> +   /* FIXME: if we are in the middle of a range we don't want to give
> +      a message.  The current interface to get_number_or_range doesn't
> +      allow us to discover this.  */
> +   printf_unfiltered ("No tracepoint number %d.\n", tpnum);
> +   return NULL;

And here.

> +   if (from_tty)
> +     printf_filtered ("Tracepoints saved to file '%s'.\n", args);
> +   return;

And here.