Re: [PATCH] Make tracepoints into breakpoints

[Joel Brobecker <brobecker@adacore.com>]

> I'd also like to look at your patch again sometime soon, to figure out
> whether it'd make sense or not for tracepoints to have their own
> breakpoint_ops routines... To be continued :)

I was too impatient, so I looked at it again ;).

Regarding the use of the breakpoint_ops routine, it makes sense for
some of them, but not all. For instance, the print_one "method"
could be kept as NULL. For the print_mention method, it would make
sense to have a dedicated method, but that method currently does not
handle the "say_where" flag.

So I'm 50/50 on this topic. I would probably have used the breakpoint_ops
myself, because I have this idealistic goal of converting everything to
using breakpoint ops one day. The downside for tracepoints is that
the implementation style gets fragmented between the "old" style and
the "new" one. The upside is that using breakpoint_ops now puts us
closer to that idealistic goal. It's still not clear to me that this
goal is attainable at all, which is why I'm not too attached to using
breakpoint_ops in your case.

I propose you let me ramble about it on my own, and do nothing (unless
you feel like it) :-).

-- 
Joel