From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26827 invoked by alias); 28 Mar 2009 08:56:36 -0000 Received: (qmail 26818 invoked by uid 22791); 28 Mar 2009 08:56:35 -0000 X-SWARE-Spam-Status: No, hits=1.8 required=5.0 tests=AWL,BAYES_00,BOTNET,J_CHICKENPOX_37,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 Mar 2009 08:56:28 +0000 Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KH700H00KPSVC00@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Sat, 28 Mar 2009 11:56:24 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.127.23.114]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KH7002PFKTZAG40@i-mtaout1.012.net.il>; Sat, 28 Mar 2009 11:56:23 +0300 (IDT) Date: Sat, 28 Mar 2009 09:07:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Make tracepoints into breakpoints In-reply-to: <49CD275B.1020003@codesourcery.com> To: Stan Shebs Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <49CD275B.1020003@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00647.txt.bz2 > Date: Fri, 27 Mar 2009 12:22:03 -0700 > From: Stan Shebs > > doc/ > * gdb.texinfo (Tracepoints): Describe tracepoints as a > special case of breakpoints. > (Enable and Disable Tracepoints): Mention deprecation. > (Listing Tracepoints): Update description and example. Thanks. I have comments about this part: > Before running such a @dfn{trace experiment}, an arbitrary number of > ! tracepoints can be set. A tracepoint is actually a special type of > ! breakpoint (@pxref{Set Breaks}), so you can manipulate it using > ! standard breakpoint commands. For instance, as with breakpoints, ^^ You have numerous places with only one space between sentences. > The @code{trace} command is very similar to the @code{break} command. > ! Its argument @var{location} can be a source line, a function name, or > ! an address in the target program. @xref{Set Breaks}. The ^^^^^^^^^^^^^^^^^ Please change this cross-reference to point to "Specify Location". > ! In addition to the basic info common to all types of breakpoints, > ! tracepoint listings may include a step count, a pass count, and the > ! list of actions. In this new text, you have removed the references to the tracepoint parameters that affect the step count, the passcount, and the actions. I think we should not drop those references, because they go a long way towards explaining what these parameters are. > The action lines are prefixed with an @code{A} so Please use @samp{A} here, not @code{A}. "A" is not a symbol, so it should be quoted (in the printed output). Other than that, the doco part of the patch is OK.