[RFC] ||/&& placement

[RFC] ||/&& placement

[Doug Evans]

Hi.  Do changes like the following fall under the "obvious" rule?

[One might want to fold the && plus its next line into one line -
I think it's reasonable, but it's orthogonal to the question I'm
asking here.]

2008-01-28  Doug Evans  <dje@google.com>

	* typeprint.c (whatis_exp): Fix formatting.

Index: typeprint.c
===================================================================
RCS file: /cvs/src/src/gdb/typeprint.c,v
retrieving revision 1.30
diff -u -p -u -p -r1.30 typeprint.c
--- typeprint.c	1 Jan 2008 22:53:13 -0000	1.30
+++ typeprint.c	29 Jan 2008 03:38:10 -0000
@@ -133,8 +133,8 @@ whatis_exp (char *exp, int show)
 
   if (objectprint)
     {
-      if (((TYPE_CODE (type) == TYPE_CODE_PTR) ||
-           (TYPE_CODE (type) == TYPE_CODE_REF))
+      if (((TYPE_CODE (type) == TYPE_CODE_PTR)
+	   || (TYPE_CODE (type) == TYPE_CODE_REF))
           &&
           (TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_CLASS))
         {

Re: [RFC] ||/&& placement

[Eli Zaretskii]

> Date: Mon, 28 Jan 2008 19:42:12 -0800 (PST)
> From: dje@google.com (Doug Evans)
> 
> Hi.  Do changes like the following fall under the "obvious" rule?

Yes.

Re: [RFC] ||/&& placement

[Joel Brobecker]

> Hi.  Do changes like the following fall under the "obvious" rule?

As Eli already said, yes.


> 2008-01-28  Doug Evans  <dje@google.com>
> 
> 	* typeprint.c (whatis_exp): Fix formatting.

But...

> -      if (((TYPE_CODE (type) == TYPE_CODE_PTR) ||
> -           (TYPE_CODE (type) == TYPE_CODE_REF))
> +      if (((TYPE_CODE (type) == TYPE_CODE_PTR)
> +	   || (TYPE_CODE (type) == TYPE_CODE_REF))
>            &&
>            (TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_CLASS))
>          {

While you're at it, could you remove the parens that look useless
and confusing to me, and also fix the formatting of the line after
the &&?

      if ((TYPE_CODE (type) == TYPE_CODE_PTR
	   || TYPE_CODE (type) == TYPE_CODE_REF)
          && TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_CLASS)

(please run the testsuite just to be extra-safe!)

Thanks,
-- 
Joel