From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] ||/&& placement
Date: Tue, 29 Jan 2008 06:42:00 -0000 [thread overview]
Message-ID: <20080129063149.GA16288@adacore.com> (raw)
In-Reply-To: <20080129034212.D1CDF1C72AA@localhost>
> Hi. Do changes like the following fall under the "obvious" rule?
As Eli already said, yes.
> 2008-01-28 Doug Evans <dje@google.com>
>
> * typeprint.c (whatis_exp): Fix formatting.
But...
> - if (((TYPE_CODE (type) == TYPE_CODE_PTR) ||
> - (TYPE_CODE (type) == TYPE_CODE_REF))
> + if (((TYPE_CODE (type) == TYPE_CODE_PTR)
> + || (TYPE_CODE (type) == TYPE_CODE_REF))
> &&
> (TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_CLASS))
> {
While you're at it, could you remove the parens that look useless
and confusing to me, and also fix the formatting of the line after
the &&?
if ((TYPE_CODE (type) == TYPE_CODE_PTR
|| TYPE_CODE (type) == TYPE_CODE_REF)
&& TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_CLASS)
(please run the testsuite just to be extra-safe!)
Thanks,
--
Joel
prev parent reply other threads:[~2008-01-29 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 4:18 Doug Evans
2008-01-29 4:53 ` Eli Zaretskii
2008-01-29 6:42 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080129063149.GA16288@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox