From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30005 invoked by alias); 29 Jan 2008 06:32:16 -0000 Received: (qmail 29997 invoked by uid 22791); 29 Jan 2008 06:32:15 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Jan 2008 06:31:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 846FC2A9643; Tue, 29 Jan 2008 01:31:53 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Q8oibLbL8iTC; Tue, 29 Jan 2008 01:31:53 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2BB0B2A9642; Tue, 29 Jan 2008 01:31:53 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 17E2EE7ACB; Mon, 28 Jan 2008 22:31:49 -0800 (PST) Date: Tue, 29 Jan 2008 06:42:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFC] ||/&& placement Message-ID: <20080129063149.GA16288@adacore.com> References: <20080129034212.D1CDF1C72AA@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080129034212.D1CDF1C72AA@localhost> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00668.txt.bz2 > Hi. Do changes like the following fall under the "obvious" rule? As Eli already said, yes. > 2008-01-28 Doug Evans > > * typeprint.c (whatis_exp): Fix formatting. But... > - if (((TYPE_CODE (type) == TYPE_CODE_PTR) || > - (TYPE_CODE (type) == TYPE_CODE_REF)) > + if (((TYPE_CODE (type) == TYPE_CODE_PTR) > + || (TYPE_CODE (type) == TYPE_CODE_REF)) > && > (TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_CLASS)) > { While you're at it, could you remove the parens that look useless and confusing to me, and also fix the formatting of the line after the &&? if ((TYPE_CODE (type) == TYPE_CODE_PTR || TYPE_CODE (type) == TYPE_CODE_REF) && TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_CLASS) (please run the testsuite just to be extra-safe!) Thanks, -- Joel