Re: [5/9] Associate parsed condition with location

[Eli Zaretskii <eliz@gnu.org>]

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 22 Sep 2007 21:53:22 +0400
> Cc: gdb-patches@sources.redhat.com
> 
> 
> On Saturday 08 September 2007 15:11:40 Eli Zaretskii wrote:
> > > From: Vladimir Prus <vladimir@codesourcery.com>
> > > Date: Sat, 8 Sep 2007 00:42:24 +0400
> > > 
> > > 	* breakpoint.c: Adjust.
> > > 	* tui/tui-winsource.c: Adjust.
> > 
> > Nitpicking: these aren't, strictly speaking, valid ChangeLog entries,
> > because they don't name the functions where the changes were made.
> 
> I've added the list of functions.

Thanks.  However:

> 	* breakpoint.c (condition_command, bpstat_stop_status,
> 	print_one_breakpoint, allocate_bp_location,
> 	solib_load_unload_1, create_fork_vfork_event_catchpoint,
> 	create_exec_event_catchpoint, create_breakpoints,
> 	break_command_1, watch_command_1, handle_gnu_v3_exceptions,
> 	create_ada_exception_breakpoint, set_breakpoint_sal,
> 	delete_breakpoint, breakpoint_re_set_one): Adjust.		

When a list of functions is longer than one line, it should be
formatted like this:

 	* breakpoint.c (condition_command, bpstat_stop_status)
 	(print_one_breakpoint, allocate_bp_location)
 	(solib_load_unload_1, create_fork_vfork_event_catchpoint)
 	(create_exec_event_catchpoint, create_breakpoints)
 	(break_command_1, watch_command_1, handle_gnu_v3_exceptions)
 	(create_ada_exception_breakpoint, set_breakpoint_sal)
 	(delete_breakpoint, breakpoint_re_set_one): Adjust.		

(the reason is to help Emacs highlight the function names correctly).
Believe it or not, but this is in the GNU Coding Standards.

> > I think we should use ``location'' instead of ``PC'', since you make
> > the change for watchpoints as well, where the PC is irrelevant.
> 
> Changed.
> 
> Is the attached fine with you?

Yes.  Thanks.