Re: [5/9] Associate parsed condition with location

[Eli Zaretskii <eliz@gnu.org>]

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 8 Sep 2007 00:42:24 +0400
> 
> 	* breakpoint.c: Adjust.
> 	* tui/tui-winsource.c: Adjust.

Nitpicking: these aren't, strictly speaking, valid ChangeLog entries,
because they don't name the functions where the changes were made.

> --- gdb/breakpoint.h	(/work/mb_mainline/4_bpstat_owner)	(revision 4741)
> +++ gdb/breakpoint.h	(/work/mb_mainline/5_per_loc_cond)	(revision 4741)
> @@ -243,6 +243,13 @@ struct bp_location
>       than reference counting.  */
>    struct breakpoint *owner;
>  
> +  /* Conditional.  Break only if this expression's value is nonzero.  
> +     Unlike string form of condition, which is associated with breakpoint,
> +     this is associated with location, since if breakpoint has several
> +     PC locations, the evaluation of expression can be different for
> +     different PCs.  */
> +  struct expression *cond;

I think we should use ``location'' instead of ``PC'', since you make
the change for watchpoints as well, where the PC is irrelevant.