From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10270 invoked by alias); 8 Sep 2007 11:12:02 -0000 Received: (qmail 10262 invoked by uid 22791); 8 Sep 2007 11:12:02 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 08 Sep 2007 11:11:57 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-141-251.inter.net.il [80.230.141.251]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id DOM22476 (AUTH halo1); Sat, 8 Sep 2007 14:11:38 +0300 (IDT) Date: Sat, 08 Sep 2007 11:12:00 -0000 Message-Id: From: Eli Zaretskii To: Vladimir Prus CC: gdb-patches@sources.redhat.com In-reply-to: <200709080042.24484.vladimir@codesourcery.com> (message from Vladimir Prus on Sat, 8 Sep 2007 00:42:24 +0400) Subject: Re: [5/9] Associate parsed condition with location Reply-to: Eli Zaretskii References: <200709080042.24484.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00106.txt.bz2 > From: Vladimir Prus > Date: Sat, 8 Sep 2007 00:42:24 +0400 > > * breakpoint.c: Adjust. > * tui/tui-winsource.c: Adjust. Nitpicking: these aren't, strictly speaking, valid ChangeLog entries, because they don't name the functions where the changes were made. > --- gdb/breakpoint.h (/work/mb_mainline/4_bpstat_owner) (revision 4741) > +++ gdb/breakpoint.h (/work/mb_mainline/5_per_loc_cond) (revision 4741) > @@ -243,6 +243,13 @@ struct bp_location > than reference counting. */ > struct breakpoint *owner; > > + /* Conditional. Break only if this expression's value is nonzero. > + Unlike string form of condition, which is associated with breakpoint, > + this is associated with location, since if breakpoint has several > + PC locations, the evaluation of expression can be different for > + different PCs. */ > + struct expression *cond; I think we should use ``location'' instead of ``PC'', since you make the change for watchpoints as well, where the PC is irrelevant.