From: Vladimir Prus <vladimir@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [5/9] Associate parsed condition with location
Date: Sat, 22 Sep 2007 18:43:00 -0000 [thread overview]
Message-ID: <200709222242.51850.vladimir@codesourcery.com> (raw)
In-Reply-To: <uhclmzh1e.fsf@gnu.org>
On Saturday 22 September 2007 22:33:33 Eli Zaretskii wrote:
> > From: Vladimir Prus <vladimir@codesourcery.com>
> > Date: Sat, 22 Sep 2007 21:53:22 +0400
> > Cc: gdb-patches@sources.redhat.com
> >
> >
> > On Saturday 08 September 2007 15:11:40 Eli Zaretskii wrote:
> > > > From: Vladimir Prus <vladimir@codesourcery.com>
> > > > Date: Sat, 8 Sep 2007 00:42:24 +0400
> > > >
> > > > * breakpoint.c: Adjust.
> > > > * tui/tui-winsource.c: Adjust.
> > >
> > > Nitpicking: these aren't, strictly speaking, valid ChangeLog entries,
> > > because they don't name the functions where the changes were made.
> >
> > I've added the list of functions.
>
> Thanks. However:
>
> > * breakpoint.c (condition_command, bpstat_stop_status,
> > print_one_breakpoint, allocate_bp_location,
> > solib_load_unload_1, create_fork_vfork_event_catchpoint,
> > create_exec_event_catchpoint, create_breakpoints,
> > break_command_1, watch_command_1, handle_gnu_v3_exceptions,
> > create_ada_exception_breakpoint, set_breakpoint_sal,
> > delete_breakpoint, breakpoint_re_set_one): Adjust.
>
> When a list of functions is longer than one line, it should be
> formatted like this:
>
> * breakpoint.c (condition_command, bpstat_stop_status)
> (print_one_breakpoint, allocate_bp_location)
> (solib_load_unload_1, create_fork_vfork_event_catchpoint)
> (create_exec_event_catchpoint, create_breakpoints)
> (break_command_1, watch_command_1, handle_gnu_v3_exceptions)
> (create_ada_exception_breakpoint, set_breakpoint_sal)
> (delete_breakpoint, breakpoint_re_set_one): Adjust.
>
> (the reason is to help Emacs highlight the function names correctly).
> Believe it or not, but this is in the GNU Coding Standards.
Ehm. I always though that it's editor that should adjust to coding
conventions, not the other way around, but I'm not going to argue
this point.
I'll adjust and commit.
Thanks,
Volodya
prev parent reply other threads:[~2007-09-22 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 20:42 Vladimir Prus
2007-09-08 11:12 ` Eli Zaretskii
2007-09-08 11:27 ` Vladimir Prus
2007-09-08 12:17 ` Eli Zaretskii
2007-09-08 13:46 ` Daniel Jacobowitz
2007-09-08 16:17 ` Eli Zaretskii
2007-09-08 16:50 ` Daniel Jacobowitz
2007-09-22 17:53 ` Vladimir Prus
2007-09-22 18:33 ` Eli Zaretskii
2007-09-22 18:43 ` Vladimir Prus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709222242.51850.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox