From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24813 invoked by alias); 22 Sep 2007 18:43:02 -0000 Received: (qmail 24801 invoked by uid 22791); 22 Sep 2007 18:43:02 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 22 Sep 2007 18:43:00 +0000 Received: (qmail 21223 invoked from network); 22 Sep 2007 18:42:58 -0000 Received: from unknown (HELO h38.net64.aknet.ru) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Sep 2007 18:42:58 -0000 From: Vladimir Prus To: Eli Zaretskii Subject: Re: [5/9] Associate parsed condition with location Date: Sat, 22 Sep 2007 18:43:00 -0000 User-Agent: KMail/1.9.6 Cc: gdb-patches@sources.redhat.com References: <200709080042.24484.vladimir@codesourcery.com> <200709222153.22298.vladimir@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709222242.51850.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00311.txt.bz2 On Saturday 22 September 2007 22:33:33 Eli Zaretskii wrote: > > From: Vladimir Prus > > Date: Sat, 22 Sep 2007 21:53:22 +0400 > > Cc: gdb-patches@sources.redhat.com > > > > > > On Saturday 08 September 2007 15:11:40 Eli Zaretskii wrote: > > > > From: Vladimir Prus > > > > Date: Sat, 8 Sep 2007 00:42:24 +0400 > > > > > > > > * breakpoint.c: Adjust. > > > > * tui/tui-winsource.c: Adjust. > > > > > > Nitpicking: these aren't, strictly speaking, valid ChangeLog entries, > > > because they don't name the functions where the changes were made. > > > > I've added the list of functions. > > Thanks. However: > > > * breakpoint.c (condition_command, bpstat_stop_status, > > print_one_breakpoint, allocate_bp_location, > > solib_load_unload_1, create_fork_vfork_event_catchpoint, > > create_exec_event_catchpoint, create_breakpoints, > > break_command_1, watch_command_1, handle_gnu_v3_exceptions, > > create_ada_exception_breakpoint, set_breakpoint_sal, > > delete_breakpoint, breakpoint_re_set_one): Adjust. > > When a list of functions is longer than one line, it should be > formatted like this: > > * breakpoint.c (condition_command, bpstat_stop_status) > (print_one_breakpoint, allocate_bp_location) > (solib_load_unload_1, create_fork_vfork_event_catchpoint) > (create_exec_event_catchpoint, create_breakpoints) > (break_command_1, watch_command_1, handle_gnu_v3_exceptions) > (create_ada_exception_breakpoint, set_breakpoint_sal) > (delete_breakpoint, breakpoint_re_set_one): Adjust. > > (the reason is to help Emacs highlight the function names correctly). > Believe it or not, but this is in the GNU Coding Standards. Ehm. I always though that it's editor that should adjust to coding conventions, not the other way around, but I'm not going to argue this point. I'll adjust and commit. Thanks, Volodya