From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20127 invoked by alias); 22 Sep 2007 18:33:43 -0000 Received: (qmail 20117 invoked by uid 22791); 22 Sep 2007 18:33:43 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 22 Sep 2007 18:33:40 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-229-122-46.inter.net.il [84.229.122.46]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id DRN78881 (AUTH halo1); Sat, 22 Sep 2007 20:33:34 +0200 (IST) Date: Sat, 22 Sep 2007 18:33:00 -0000 Message-Id: From: Eli Zaretskii To: Vladimir Prus CC: gdb-patches@sources.redhat.com In-reply-to: <200709222153.22298.vladimir@codesourcery.com> (message from Vladimir Prus on Sat, 22 Sep 2007 21:53:22 +0400) Subject: Re: [5/9] Associate parsed condition with location Reply-to: Eli Zaretskii References: <200709080042.24484.vladimir@codesourcery.com> <200709222153.22298.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00310.txt.bz2 > From: Vladimir Prus > Date: Sat, 22 Sep 2007 21:53:22 +0400 > Cc: gdb-patches@sources.redhat.com > > > On Saturday 08 September 2007 15:11:40 Eli Zaretskii wrote: > > > From: Vladimir Prus > > > Date: Sat, 8 Sep 2007 00:42:24 +0400 > > > > > > * breakpoint.c: Adjust. > > > * tui/tui-winsource.c: Adjust. > > > > Nitpicking: these aren't, strictly speaking, valid ChangeLog entries, > > because they don't name the functions where the changes were made. > > I've added the list of functions. Thanks. However: > * breakpoint.c (condition_command, bpstat_stop_status, > print_one_breakpoint, allocate_bp_location, > solib_load_unload_1, create_fork_vfork_event_catchpoint, > create_exec_event_catchpoint, create_breakpoints, > break_command_1, watch_command_1, handle_gnu_v3_exceptions, > create_ada_exception_breakpoint, set_breakpoint_sal, > delete_breakpoint, breakpoint_re_set_one): Adjust. When a list of functions is longer than one line, it should be formatted like this: * breakpoint.c (condition_command, bpstat_stop_status) (print_one_breakpoint, allocate_bp_location) (solib_load_unload_1, create_fork_vfork_event_catchpoint) (create_exec_event_catchpoint, create_breakpoints) (break_command_1, watch_command_1, handle_gnu_v3_exceptions) (create_ada_exception_breakpoint, set_breakpoint_sal) (delete_breakpoint, breakpoint_re_set_one): Adjust. (the reason is to help Emacs highlight the function names correctly). Believe it or not, but this is in the GNU Coding Standards. > > I think we should use ``location'' instead of ``PC'', since you make > > the change for watchpoints as well, where the PC is irrelevant. > > Changed. > > Is the attached fine with you? Yes. Thanks.