Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [MI non-stop 04/11] Implement --thread and --frame.
Date: Sat, 28 Jun 2008 17:30:00 -0000	[thread overview]
Message-ID: <uej6hcw5i.fsf@gnu.org> (raw)
In-Reply-To: <200806282044.14246.vladimir@codesourcery.com>

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Sat, 28 Jun 2008 20:44:14 +0400
> 
> 
> +  if (parse->frame != -1 && !parse->thread == -1)
> +    error ("Cannot specify --frame without --thread");

Why is this error message not in _(), while all the rest are?

Btw, do we at all want error messages issued by MI commands
translated?  MI commands are invoked by a program, so error messages
we generate should be understandable by a program, which probably
means they should not be translated.

> +      if (strncmp (chp, "--thread", 8) == 0)

Please, let's not use literal constants in this context, let's use
sizeof instead.

> +	  parse->frame = strtol (chp, &chp, 10);

Do we really want to disallow non-decimal numbers here?  What about
hex frame numbers?


  reply	other threads:[~2008-06-28 17:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-28 16:54 Vladimir Prus
2008-06-28 17:30 ` Eli Zaretskii [this message]
2008-06-28 18:00   ` Vladimir Prus
2008-06-28 18:23     ` Eli Zaretskii
2008-06-28 18:26       ` Marc Khouzam
2008-06-29  6:10       ` Vladimir Prus
2008-06-29 20:15         ` Eli Zaretskii
2008-07-01  3:53           ` Vladimir Prus
2008-06-30 18:35       ` Michael Snyder
2008-06-30 18:42         ` Daniel Jacobowitz
2008-06-28 18:13 ` Marc Khouzam
2008-06-28 18:26   ` Eli Zaretskii
2008-06-28 18:27     ` Marc Khouzam
2008-06-29  6:08   ` Vladimir Prus
2008-06-29 19:42     ` Eli Zaretskii
2008-06-30  0:09       ` Tom Tromey
2008-06-30  8:39         ` Eli Zaretskii
2008-06-30 18:35         ` Michael Snyder
2008-06-30 19:19           ` Tom Tromey
2008-06-30 20:47             ` Daniel Jacobowitz
2008-07-11 12:50 ` Daniel Jacobowitz
2008-07-12 20:15 ` Ulrich Weigand
2008-07-13  3:54   ` Vladimir Prus
2008-07-15 18:42     ` Ulrich Weigand
2008-07-13  5:45 ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uej6hcw5i.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox