Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: vladimir@codesourcery.com (Vladimir Prus)
Cc: gdb-patches@sources.redhat.com
Subject: Re: [MI non-stop 04/11] Implement --thread and --frame.
Date: Sat, 12 Jul 2008 20:15:00 -0000	[thread overview]
Message-ID: <200807122014.m6CKEgkP016422@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200806282044.14246.vladimir@codesourcery.com> from "Vladimir Prus" at Jun 28, 2008 08:44:14 PM

Vladimir Prus wrote:

>  mi_cmd_execute (struct mi_parse *parse)
>  {
>    struct cleanup *cleanup = make_cleanup (null_cleanup, NULL);
> +  char *thread_str;
> +  char *frame_str;
> +  int thread;
> +  int i;

[snip]

> +	error (_("Invalid frame id: %s"), frame_str);

This variable is used uninitialized, which breaks the -Werror
build for me.

(Also, it seems the other local variables introduced by this
patch are never used ...)

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  parent reply	other threads:[~2008-07-12 20:15 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-28 16:54 Vladimir Prus
2008-06-28 17:30 ` Eli Zaretskii
2008-06-28 18:00   ` Vladimir Prus
2008-06-28 18:23     ` Eli Zaretskii
2008-06-28 18:26       ` Marc Khouzam
2008-06-29  6:10       ` Vladimir Prus
2008-06-29 20:15         ` Eli Zaretskii
2008-07-01  3:53           ` Vladimir Prus
2008-06-30 18:35       ` Michael Snyder
2008-06-30 18:42         ` Daniel Jacobowitz
2008-06-28 18:13 ` Marc Khouzam
2008-06-28 18:26   ` Eli Zaretskii
2008-06-28 18:27     ` Marc Khouzam
2008-06-29  6:08   ` Vladimir Prus
2008-06-29 19:42     ` Eli Zaretskii
2008-06-30  0:09       ` Tom Tromey
2008-06-30  8:39         ` Eli Zaretskii
2008-06-30 18:35         ` Michael Snyder
2008-06-30 19:19           ` Tom Tromey
2008-06-30 20:47             ` Daniel Jacobowitz
2008-07-11 12:50 ` Daniel Jacobowitz
2008-07-12 20:15 ` Ulrich Weigand [this message]
2008-07-13  3:54   ` Vladimir Prus
2008-07-15 18:42     ` Ulrich Weigand
2008-07-13  5:45 ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807122014.m6CKEgkP016422@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox