From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1058 invoked by alias); 12 Jul 2008 20:15:54 -0000 Received: (qmail 1049 invoked by uid 22791); 12 Jul 2008 20:15:54 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 12 Jul 2008 20:15:29 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id m6CKEhRP377270 for ; Sat, 12 Jul 2008 20:14:43 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m6CKEhCR3838092 for ; Sat, 12 Jul 2008 22:14:43 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m6CKEh5S016426 for ; Sat, 12 Jul 2008 22:14:43 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m6CKEgkP016422; Sat, 12 Jul 2008 22:14:42 +0200 Message-Id: <200807122014.m6CKEgkP016422@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Sat, 12 Jul 2008 22:14:42 +0200 Subject: Re: [MI non-stop 04/11] Implement --thread and --frame. To: vladimir@codesourcery.com (Vladimir Prus) Date: Sat, 12 Jul 2008 20:15:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sources.redhat.com In-Reply-To: <200806282044.14246.vladimir@codesourcery.com> from "Vladimir Prus" at Jun 28, 2008 08:44:14 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00237.txt.bz2 Vladimir Prus wrote: > mi_cmd_execute (struct mi_parse *parse) > { > struct cleanup *cleanup = make_cleanup (null_cleanup, NULL); > + char *thread_str; > + char *frame_str; > + int thread; > + int i; [snip] > + error (_("Invalid frame id: %s"), frame_str); This variable is used uninitialized, which breaks the -Werror build for me. (Also, it seems the other local variables introduced by this patch are never used ...) Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com