Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Vladimir Prus <vladimir@codesourcery.com>,
	marc.khouzam@ericsson.com,
	        gdb-patches@sources.redhat.com
Subject: Re: [MI non-stop 04/11] Implement --thread and --frame.
Date: Mon, 30 Jun 2008 00:09:00 -0000	[thread overview]
Message-ID: <m3hcbc111o.fsf@fleche.redhat.com> (raw)
In-Reply-To: <uzlp4b0a5.fsf@gnu.org> (Eli Zaretskii's message of "Sun\, 29 Jun 2008 20\:48\:02 +0300")

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

Eli> I think the variant with threadStr[] and sizeof - 1 is more
Eli> maintainable, especially since not everyone uses Emacs.  Moreover, a
Eli> literal constant makes code a bit harder to read, since I need to
Eli> count characters after you, to be sure I understand exactly what your
Eli> code does.

libcpp uses:

#define DSC(str) (const unsigned char *)str, sizeof str - 1

Sometimes this is a bit obscure but it has the nice quality that you
can use the string constant in the place where it is needed, and you
only have to write it once.  (The 'unsigned' is because libcpp uses
unsigned chars everywhere -- gdb wouldn't need this.)

Eli> (Btw, in stock Emacs "ESC =" counts _lines_ in region, not characters.
Eli> You probably have some customization that does this.)

FWIW count-lines-region displays the number of characters as well as
the number of lines.

Tom


  reply	other threads:[~2008-06-29 19:42 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-28 16:54 Vladimir Prus
2008-06-28 17:30 ` Eli Zaretskii
2008-06-28 18:00   ` Vladimir Prus
2008-06-28 18:23     ` Eli Zaretskii
2008-06-28 18:26       ` Marc Khouzam
2008-06-29  6:10       ` Vladimir Prus
2008-06-29 20:15         ` Eli Zaretskii
2008-07-01  3:53           ` Vladimir Prus
2008-06-30 18:35       ` Michael Snyder
2008-06-30 18:42         ` Daniel Jacobowitz
2008-06-28 18:13 ` Marc Khouzam
2008-06-28 18:26   ` Eli Zaretskii
2008-06-28 18:27     ` Marc Khouzam
2008-06-29  6:08   ` Vladimir Prus
2008-06-29 19:42     ` Eli Zaretskii
2008-06-30  0:09       ` Tom Tromey [this message]
2008-06-30  8:39         ` Eli Zaretskii
2008-06-30 18:35         ` Michael Snyder
2008-06-30 19:19           ` Tom Tromey
2008-06-30 20:47             ` Daniel Jacobowitz
2008-07-11 12:50 ` Daniel Jacobowitz
2008-07-12 20:15 ` Ulrich Weigand
2008-07-13  3:54   ` Vladimir Prus
2008-07-15 18:42     ` Ulrich Weigand
2008-07-13  5:45 ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3hcbc111o.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=marc.khouzam@ericsson.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox